MBL-1268: Check for 'canceled' param in login redirect #1972
+35
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1268/cancel-button
branch
from
5c27dff
to
68e79e6
Compare
| @@ -432,7 +432,7 @@ public final class LoginToutViewController: UIViewController, MFMailComposeViewC | |||
| ) | |||
| alert.addAction(UIAlertAction(title: Strings.login_errors_button_ok(), style: .cancel)) | |||
| self?.present(alert, animated: true) | |||
| case .cancelled: | |||
| case .canceled: | |||
There was a problem hiding this comment.
Renamed for sanity since the web param is also canceled with one l
amy-at-kickstarter
requested review from
a team,
scottkicks and
ifosli
and removed request for
a team
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1268/cancel-button
branch
from
68e79e6
to
2e2db3e
Compare
scottkicks
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Check if redirect was canceled.
🤔 Why
Otherwise, if the user cancels somewhere inside the webview, we would show an error message, which looks a little silly.
https://github.com/kickstarter/ios-oss/assets/146007185/2a073c11-be58-4217-9385-f29c608d19b6