Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions found in the login with OAuth flow #1976

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Fix regressions found in the login with OAuth flow #1976

merged 4 commits into from
Mar 14, 2024

Commits on Mar 13, 2024

  1. Make the display of login/logout/oauth buttons reactive. 

    This way, config flag changes that occur shortly after launch will update the UI appropriately.
    @amy-at-kickstarter
    amy-at-kickstarter committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ad0b58a View commit details
    Browse the repository at this point in the history

  2. Add tests for OAuth login button in LoginToutViewModelTests

    @amy-at-kickstarter
    amy-at-kickstarter committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5b81362 View commit details
    Browse the repository at this point in the history

  3. Make featureLoginWithOAuthEnabled default to true, if no remote or lo… 

    …cal config is set
    @amy-at-kickstarter
    amy-at-kickstarter committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5abea9d View commit details
    Browse the repository at this point in the history

  4. Change per review #1976

    @amy-at-kickstarter
    amy-at-kickstarter committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    cc41eda View commit details
    Browse the repository at this point in the history