Add short delay before presenting push notification dialog #1979
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-push-registration-after-oauth-login
branch
from
689e269
to
c75e7fc
Compare
ifosli
approved these changes
Mar 14, 2024
…t accidental dismissal)
amy-at-kickstarter
force-pushed
the
feat/adyer/fix-push-registration-after-oauth-login
branch
from
c75e7fc
to
2822e8b
Compare
amy-at-kickstarter
deleted the
feat/adyer/fix-push-registration-after-oauth-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add a 0.5 second delay before presenting our push notification permission dialog.
🤔 Why
When you sign in with OAuth, this permission dialog was showing up only rarely. I dug into the code and found that we were calling everything correctly, but the popup was disappearing, somehow.
My best guess is that something internal is dismissing both the web authentication screen and, since it happens at the same time, the push notification dialog. Adding a short delay before presenting the push notification dialog solves this problem, and doesn't feel any different as a user.
Mar-14-2024.16-01-24.mp4