[MBL-1208] Part 4: Continue CTA Section #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
requested review from
a team and
ifosli
and removed request for
a team
amy-at-kickstarter
approved these changes
Mar 18, 2024
|
|
||
| private enum Layout { | ||
| enum Button { | ||
| static let minHeight: CGFloat = 48.0 |
There was a problem hiding this comment.
Is this not in our design system somewhere?
|
|
||
| _ = self.continueButton | ||
| |> greenButtonStyle | ||
| |> UIButton.lens.title(for: .normal) %~ { _ in Strings.Continue() } |
There was a problem hiding this comment.
Nit/non-blocking: Mentioned this in an earlier PR but I'd prefer us to move away from Prelude code in bindStyles whenever we can avoid it.
| } | ||
| } | ||
|
|
||
| private func attributedCurrency(with project: Project, total: Double) -> NSAttributedString? { |
There was a problem hiding this comment.
Extremely teeny nit: This method name would be clearer if it was withProject: instead of just with:
| private func attributedCurrency(with project: Project, total: Double) -> NSAttributedString? { | ||
| let defaultAttributes = checkoutCurrencyDefaultAttributes() | ||
| .withAllValuesFrom([.foregroundColor: UIColor.ksr_support_700]) | ||
| let projectCurrencyCountry = projectCountry(forCurrency: project.stats.currency) ?? project.country |
There was a problem hiding this comment.
Do we expect this fall-through to ever have to happen? I wonder if we should just change the type of project.currency to be a forced non-nil value, since it would be pretty odd if we didn't have that information from the server.
| project, | ||
| pledgeTotal | ||
| ) | ||
| .map { project, total in (project, total) } |
There was a problem hiding this comment.
Nit: this map is a no-op, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds the CTA section to the bottom of the screen.
Includes a continue button that will navigate to the final checkout screen and displays the current pledge total.
🤔 Why
We need a way to confirm pledge details.
🛠 How
creates a new
ConfirmDetailsContinueCTAViewand adds it toConfirmDetailsViewControllerfollowing the designs: https://www.figma.com/file/sFfDKxlJ2tiuq1xgIsaoiI/Late-Campaign-Backings?type=design&node-id=73-5025&mode=design&t=4iAXblqSygfASSvB-0👀 See
✅ Acceptance criteria