[MBL-1210] Post campaign checkout #1984

ifosli · 2024-03-19T17:05:44Z

📲 What

Add a mostly completed post campaign checkout page. This page is presented after the confirm details page. See TODO section for remaining work.

Note: This (including the TODOs) only update the UI. The payment sheet is not wired up yet at all.

👀 See

Jira

♿️ Accessibility

Tap targets use minimum of 44x44 pts dimensions
Dynamic Type should be fine since this isn't adding any new components

Note: VoiceOver will be tested later to unblock work.

✅ Acceptance criteria

Checkout page shows up (for rewards that include shipping) and matches the mocks with the exceptions listed below

⏰ TODO

TODO in follow-up prs to unblock work

Update rewards summary table to fully support the checkout page. This requires supporting nil shipping and figuring out why bonus support hides on this page
Update CTA to a) show "charged immediately" warning, probably by creating a postCampaignPledge context and b) properly set fields & respond to login flow
Add snapshot tests once the above UI issues are fixed

ifosli · 2024-03-19T18:26:17Z

...eatures/PledgePaymentMethods/Controller/PostCampaignPledgeRewardsSummaryViewController.swift

@@ -44,6 +44,8 @@ final class PostCampaignPledgeRewardsSummaryViewController: UIViewController {
  override func viewDidLoad() {
    super.viewDidLoad()

+    self.view.isHidden = true
+    self.pledgeTotalViewController.view.isHidden = true


Note: It's important to never put anything in bindStyles that can be overwritten later. Anything to do with initial state needs to go in viewDidLoad instead. I spent hours trying to debug why the table wasn't showing up on the checkout screen 😭

This actually causes a slight issue where a small piece of this view is shown while the table data loads. This isn't as smooth of a UX IMO but I'm not sure what the fix is.

Thanks for calling that out! For some reason, the separator view was still showing... I just hid that as well and the table is back to being fully hidden before data loads!

ifosli · 2024-03-19T18:27:06Z

Kickstarter-iOS/Features/PledgeView/Controllers/PledgeViewControllerHelpers.swift

+import Library
+import UIKit
+
+struct PledgeViewControllerHelpers {


This function is literally copy-pasted from the pledgeViewController with no changes; no need to review carefully.

nativeksr · 2024-03-19T18:27:34Z

	1 Warning
⚠️	Big PR

SwiftFormat found issues:

File	Rules
Kickstarter-iOS/Features/PledgePaymentMethods/Controller/PostCampaignPledgeRewardsSummaryViewController.swift:49:1	warning: (redundantSelf) Insert/remove explicit self where applicable.
Kickstarter-iOS/Features/PledgePaymentMethods/Controller/PostCampaignPledgeRewardsSummaryViewController.swift:168:1	warning: (indent) Indent code in accordance with the scope level.
Kickstarter-iOS/Features/PledgePaymentMethods/Controller/PostCampaignPledgeRewardsSummaryViewController.swift:169:1	warning: (blankLinesAroundMark) Insert blank line before and after MARK: comments.

Generated by 🚫 Danger

ifosli · 2024-03-19T18:27:57Z

Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift

+  private lazy var pledgeCTAContainerView: PledgeViewCTAContainerView = {
+    PledgeViewCTAContainerView(frame: .zero)
+      |> \.translatesAutoresizingMaskIntoConstraints .~ false
+    // TODO: Add self as delegate and add support for delegate methods.


I wasn't sure if we have a ticket for wiring up the payment flow here; let me know if we do and I'll link it

ifosli

Note: The initial prs are neatly organized if you want to review them in order. However, that merge conflict was evil, so I gave up on organized commits after that.

scottkicks

This first piece is looking good!
We just need the bonus support amount to also be shown in the pledge rewards summary table. It looks like the bonus amount is being passed along to the table correctly. I'm not seeing why the table isn't displaying the bonus item row though.

scottkicks · 2024-03-19T19:04:09Z

...eatures/PledgePaymentMethods/Controller/PostCampaignPledgeRewardsSummaryViewController.swift

@@ -44,6 +44,8 @@ final class PostCampaignPledgeRewardsSummaryViewController: UIViewController {
  override func viewDidLoad() {
    super.viewDidLoad()

+    self.view.isHidden = true
+    self.pledgeTotalViewController.view.isHidden = true


This actually causes a slight issue where a small piece of this view is shown while the table data loads. This isn't as smooth of a UX IMO but I'm not sure what the fix is.

scottkicks

GTG one the circleci issues are resolved

ifosli added 8 commits March 18, 2024 13:53

Create basic checkout vc

92eaf5f

Create view model

0016c21

Add checkoutVC to view hierarchy with bad data

0bfa38a

Show basic pledge CTA

00a1e71

Add payment methods

82c5157

Add disclaimer view

23df2c7

Create and use PostCampaignCheckoutData

aefa6df

Add pledge summary

8ba23e8

ifosli self-assigned this Mar 19, 2024

ifosli added 2 commits March 19, 2024 11:27

Merge branch 'main' into postCampaignCheckout

2687655

Fix padding

5cbd484

ifosli commented Mar 19, 2024

View reviewed changes

ifosli force-pushed the postCampaignCheckout branch from b9ac374 to 36c0749 Compare March 19, 2024 18:30

ifosli commented Mar 19, 2024

View reviewed changes

Fix merge commit

cce1e8d

ifosli force-pushed the postCampaignCheckout branch from 36c0749 to cce1e8d Compare March 19, 2024 18:35

ifosli marked this pull request as ready for review March 19, 2024 18:35

ifosli requested a review from scottkicks March 19, 2024 18:36

scottkicks requested changes Mar 19, 2024

View reviewed changes

scottkicks approved these changes Mar 19, 2024

View reviewed changes

ifosli added 2 commits March 19, 2024 14:46

Hide entire table before it has data

0ac748b

Merge branch 'main' into postCampaignCheckout

43564f6

ifosli merged commit 09df982 into main Mar 20, 2024
5 checks passed

ifosli deleted the postCampaignCheckout branch March 20, 2024 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-1210] Post campaign checkout #1984

[MBL-1210] Post campaign checkout #1984

ifosli commented Mar 19, 2024 •

edited

ifosli Mar 19, 2024

scottkicks Mar 19, 2024 •

edited

ifosli Mar 19, 2024

ifosli Mar 19, 2024

nativeksr commented Mar 19, 2024 •

edited

ifosli Mar 19, 2024

ifosli left a comment

scottkicks left a comment

scottkicks Mar 19, 2024 •

edited

scottkicks left a comment

[MBL-1210] Post campaign checkout #1984

[MBL-1210] Post campaign checkout #1984

Conversation

ifosli commented Mar 19, 2024 • edited

📲 What

👀 See

♿️ Accessibility

✅ Acceptance criteria

⏰ TODO

ifosli Mar 19, 2024

Choose a reason for hiding this comment

scottkicks Mar 19, 2024 • edited

Choose a reason for hiding this comment

ifosli Mar 19, 2024

Choose a reason for hiding this comment

ifosli Mar 19, 2024

Choose a reason for hiding this comment

nativeksr commented Mar 19, 2024 • edited

SwiftFormat found issues:

ifosli Mar 19, 2024

Choose a reason for hiding this comment

ifosli left a comment

Choose a reason for hiding this comment

scottkicks left a comment

Choose a reason for hiding this comment

scottkicks Mar 19, 2024 • edited

Choose a reason for hiding this comment

scottkicks left a comment

Choose a reason for hiding this comment

ifosli commented Mar 19, 2024 •

edited

scottkicks Mar 19, 2024 •

edited

nativeksr commented Mar 19, 2024 •

edited

scottkicks Mar 19, 2024 •

edited