Rename PaymentMethodsViewController to PaymentMethodSettingsViewController for clarity #1986
+28
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
changed the title
amy-at-kickstarter
force-pushed
the
feat/adyer/rename-paymentmethodsviewcontroller
branch
from
62779be
to
851389b
Compare
amy-at-kickstarter
requested review from
a team and
scottkicks
and removed request for
a team
amy-at-kickstarter
force-pushed
the
feat/adyer/rename-paymentmethodsviewcontroller
branch
from
4c04ddd
to
b877bd2
Compare
amy-at-kickstarter
deleted the
feat/adyer/rename-paymentmethodsviewcontroller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Rename
PaymentMethodsViewControllertoPaymentMethodSettingsViewController🤔 Why
While looking at post-campaign backing changes, I got pretty confused why we have
PaymentMethodsViewControlleras well asPledgePaymentMethodsViewController. Once I learned thatPaymentMethodsViewControlleris only used in your user profile, it made much more sense. This rename should make that more obvious.