Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO TICKET] Create Checkout Fails When Pledging With No Reward #1988

Merged
merged 1 commit into from Mar 20, 2024

Conversation

scottkicks
Copy link
Contributor

πŸ“² What

When pledging with no reward, CreateCheckout fails

πŸ€” Why

There is technically a reward ID that is sent in this case that the backend won't recognize

πŸ›  How

When no rewards are selected set rewardIDs to an empty array. The backend expects this.

βœ… Acceptance criteria

  • When pledging with no reward, the user can continue to the checkout screen after confirming pledge details.

@scottkicks scottkicks self-assigned this Mar 20, 2024
@scottkicks scottkicks marked this pull request as ready for review March 20, 2024 17:07
@scottkicks scottkicks requested a review from ifosli March 20, 2024 17:07
@scottkicks scottkicks merged commit 66a17f5 into main Mar 20, 2024
4 checks passed
@scottkicks scottkicks deleted the scott/pcp/create-checkout-no-rewards-bug branch March 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants