Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1210] Update checkout pledge summary table #1989

Merged
merged 4 commits into from Mar 20, 2024
Merged

[MBL-1210] Update checkout pledge summary table #1989

merged 4 commits into from Mar 20, 2024
+42 −24

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Mar 20, 2024 •
edited

📲 What

Update the pledge summary table & navigation to the checkout screen to support no shipping and the no rewards case.

👀 See

Jira

No reward Pledge with bonus
image image

✅ Acceptance criteria

  • No rewards case shows correct cost
  • Shipping shows only when set
  • Bonus shows whenever it's set (and > 0).

@ifosli ifosli self-assigned this Mar 20, 2024
@ifosli ifosli marked this pull request as ready for review March 20, 2024 17:44
@ifosli ifosli requested review from a team and scottkicks and removed request for a team March 20, 2024 17:45
scottkicks
scottkicks approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@ifosli ifosli merged commit 136e9d6 into main Mar 20, 2024
5 checks passed
@ifosli ifosli deleted the nullableShipping branch March 20, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottkicks scottkicks scottkicks approved these changes

Assignees

@ifosli ifosli

Labels
post-campaign-pledging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ifosli @scottkicks