MBL-1123: Refactor PledgePaymentMethodsViewModel to use PaymentSourceSelected #1992
+76
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…editCard model object
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1123/refactor-payment-source-pt-2
branch
2 times, most recently
from
787544d
to
3ed8616
Compare
amy-at-kickstarter
force-pushed
the
feat/adyer/MBL-1123/refactor-payment-source-pt-2
branch
from
3ed8616
to
67460e2
Compare
amy-at-kickstarter
changed the title
amy-at-kickstarter
changed the title
| return nil | ||
| } | ||
| } | ||
| .map { $0.selectedPaymentMethod } |
There was a problem hiding this comment.
All this refactoring was to get this simplification!
| @@ -49,11 +49,12 @@ final class PledgePaymentMethodsViewModelTests: TestCase { | |||
| .observe(self.reloadPaymentMethodsProjectCountry.observer) | |||
| self.vm.outputs.reloadPaymentMethods.map { $0.1 } | |||
| .observe(self.reloadPaymentSheetPaymentMethodsCards.observer) | |||
| self.vm.outputs.reloadPaymentMethods.map { $0.2 }.observe(self.reloadPaymentMethodsSelectedCard.observer) | |||
| self.vm.outputs.reloadPaymentMethods.map { $0.3 } | |||
| self.vm.outputs.reloadPaymentMethods.map { data in data.selectedPaymentMethod?.paymentSourceId } | |||
There was a problem hiding this comment.
Instead of re-writing these tests to use the new-and-better output, just shimming the refactored code into the old test. We can make these tests prettier later, if we want.
amy-at-kickstarter
deleted the
feat/adyer/MBL-1123/refactor-payment-source-pt-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Refactor
PledgePaymentMethodsViewModelto usePaymentSourceSelected, instead of managing separate values for aselectedSetupIntentand aselectedCreditCard.🤔 Why
For MBL-1123, I need to pass the final selected value (whether it's from a
SetupIntent, aPaymentIntentor an existingCreditCard) back to the delegate of thePledgePaymentMethodsViewController. This refactor makes that significantly easier - we'll be able to keep the declarative nature of the screen, but be explicit about what kind of payment method is selected.The alternative would be to keep some kind of state in the
PledgePaymentMethodsViewControllerthat indicated whether or not it should use aSetupIntentor aPaymentIntent, and that felt messy in a different way.