Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PaymentSourceSelected.paymentSourceId to .savedCreditCard #1997

Merged

Conversation

amy-at-kickstarter
Copy link
Contributor

📲 What

Rename PaymentSourceSelected.paymentSourceId to .savedCreditCard

🤔 Why

This makes it slightly clearer what is actually being saved in the enum.

@amy-at-kickstarter amy-at-kickstarter marked this pull request as ready for review March 25, 2024 19:39
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@scottkicks scottkicks merged commit b9d1719 into main Mar 26, 2024
4 checks passed
@scottkicks scottkicks deleted the feat/adyer/rename-payment-source-selected-paymentsourceid branch March 26, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants