Navigate To Thank You Page On Successful Late Pledge #2008
Merged
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkicks
force-pushed
the
scott/pcp/navigate-to-thank-you
branch
from
bc10ded
to
f6f5f5f
Compare
scottkicks
requested review from
a team and
amy-at-kickstarter
and removed request for
a team
scottkicks
commented
Apr 1, 2024
Comment on lines
+377
to
+378
| return (initialData.project, reward, nil, initialData.total) | ||
| } |
There was a problem hiding this comment.
It didn't look like we needed to pass any CheckoutData in this case.
There was a problem hiding this comment.
Huh. Do regular pledges require it, or can CheckoutData be cleaned up from the ThanksPageData type?
There was a problem hiding this comment.
Yea I have a note to look at that. I couldn't see find what it was needed for honestly.
amy-at-kickstarter
approved these changes
Apr 1, 2024
Comment on lines
+377
to
+378
| return (initialData.project, reward, nil, initialData.total) | ||
| } |
There was a problem hiding this comment.
Huh. Do regular pledges require it, or can CheckoutData be cleaned up from the ThanksPageData type?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Navigates To Thank You Page On Successful Late Pledge
🤔 Why
So we can formally thank users for their pledge, show them verification, and suggest other projects to them
🛠 How
Using data we already have in the PostCampaignCheckoutViewModel, gather the data needed for the Thanks Page.
👀 See
I can't remove backings rn and only have 2 accounts that I used to test already so I can't screen record this.
✅ Acceptance criteria