MBL-1316: Use isAvailable to filter visible add-ons #2012
Merged
+171
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,7 +24,8 @@ extension Reward { | |||
| shippingRulesExpanded: $1.shippingRulesExpanded, | |||
There was a problem hiding this comment.
I'm still formulating some thoughts about how we can replace the Foo.template.lens |> ... pattern, so I used this as an opportunity to actually get into the guts of one to learn more about it.
| isUnlimitedOrAvailable | ||
| ] | ||
| .allSatisfy(isTrue) | ||
| return addOn.isAvailable ?? false |
There was a problem hiding this comment.
Replace all the start time logic with isAvailable.
| @@ -467,6 +484,7 @@ final class RewardAddOnSelectionViewModelTests: TestCase { | |||
| |> Reward.lens.remaining .~ nil | |||
| |> Reward.lens.startsAt .~ (MockDate().timeIntervalSince1970 + 30) | |||
| |> Reward.lens.endsAt .~ (MockDate().timeIntervalSince1970 + 60) | |||
| |> Reward.lens.isAvailable .~ false | |||
There was a problem hiding this comment.
This test actually includes some unavailable rewards, so updating it to reflect that.
scottkicks
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Use the GraphQL field
isAvailableto filter visible add-ons🤔 Why
Our existing implementation did not take late pledges into account, so it was filtering out add-ons that were actually still available for late pledges. I spoke with @zan-rosenthal and apparently the gold-standard solution is to use the
availablefield from GraphQL.Most of this PR is updating plumbing to get
availableintoReward.