[MBL-1307] Show processing view while payment is processing #2013

ifosli · 2024-04-01T22:09:23Z

📲 What

Show processing view while payment is processing. This prevents further user interaction until it's dismissed.

Note: It's very important that we make sure that regardless of how checkout goes/where it fails, the processing view will get dismissed. It will lock the app otherwise. The original pledge VC ties the processing view to specific API calls, but we can't do that for post campaign pledges, since we require multiple different API calls to finish the payment flow. Please help me double check that there aren't edge cases that would leave the processing screen up indefinitely!

Note: The processing screen does hide immediately once apple pay is dismissed - I have no idea why the gif is showing it weird.

👀 See

Jira

Pledge flow	Apple pay flow

✅ Acceptance criteria

Processing overlay shows when it should and hides again when it should

⏰ TODO

Add tests

ifosli · 2024-04-01T22:23:20Z

Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift

@@ -296,6 +311,7 @@ final class PostCampaignCheckoutViewController: UIViewController, MessageBannerV
        guard error == nil, status == .succeeded else {
          self.messageBannerViewController?
            .showBanner(with: .error, message: Strings.Something_went_wrong_please_try_again())
+          self.viewModel.inputs.checkoutTerminated()


I don't like how many different places we're calling checkoutTerminated in this - it feels messy. But I can't think of a better way to implement this. Let me know if y'all have any ideas.

You could write a wrapper method like

checkoutTerminated(withErrorMessage message: String?) { self.messageBannerViewController? .showBanner(with: .error, message: message ?? Strings.Something_went_wrong_please_try_again()) self.viewModel.inputs.checkoutTerminated() }

which would consolidate two of these.

That feels more confusing to me actually, since then the checkoutTerminated would sometimes be nested and sometimes not. I think I'm going to leave this as-is if you're okay with it. I also think it's clearer now that I got rid of the extraneous calls, so thanks for that call-out!

The other thing I tried was having the processing view tied directly to api calls the way the PledgeViewModel does, but it did disappear and reappear between linked calls, so I say that very much did not work.

amy-at-kickstarter · 2024-04-02T14:07:15Z

Library/ViewModels/PostCampaignCheckoutViewModel.swift

+      validateCheckoutError.mapConst(true), // Card validation error terminates flow.
+      self.checkoutTerminatedProperty.signal.mapConst(true), // Error/cancellation in VC.
+      checkoutCompleteSignal.signal.mapConst(true) // Checkout completed.
+    )


I see what you mean about worrying about edge cases in here. I don't see any obvious errors - but for readability, you could sort the merge into clearer groups of true and false.

amy-at-kickstarter

Some suggestions for clarity but overall LGTM

amy-at-kickstarter · 2024-04-02T14:07:35Z

Library/ViewModels/PostCampaignCheckoutViewModel.swift

@@ -391,10 +403,25 @@ public class PostCampaignCheckoutViewModel: PostCampaignCheckoutViewModelType,
      .map { $0 }

    self.checkoutError = checkoutCompleteSignal.signal.errors()
+
+    self.processingViewIsHidden = Signal.merge(
+      initialData.mapConst(true),


Because this property starts as true I don't think this one is necessary.

amy-at-kickstarter · 2024-04-02T14:07:54Z

Library/ViewModels/PostCampaignCheckoutViewModelTests.swift

@@ -12,11 +12,14 @@ final class PostCampaignCheckoutViewModelTests: XCTestCase {
    Never


Can you add more tests for the processing view in here?

Yeah, of course! I wanted to make sure we were on the same page about going with this approach before I wrote proper tests. But I think we're good now!

amy-at-kickstarter · 2024-04-02T14:10:21Z

Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift

@@ -296,6 +311,7 @@ final class PostCampaignCheckoutViewController: UIViewController, MessageBannerV
        guard error == nil, status == .succeeded else {
          self.messageBannerViewController?
            .showBanner(with: .error, message: Strings.Something_went_wrong_please_try_again())
+          self.viewModel.inputs.checkoutTerminated()


You could write a wrapper method like

checkoutTerminated(withErrorMessage message: String?) { self.messageBannerViewController? .showBanner(with: .error, message: message ?? Strings.Something_went_wrong_please_try_again()) self.viewModel.inputs.checkoutTerminated() }

which would consolidate two of these.

amy-at-kickstarter · 2024-04-02T14:18:41Z

Kickstarter-iOS/Features/PledgeView/Controllers/PostCampaignCheckoutViewController.swift

@@ -430,6 +447,7 @@ extension PostCampaignCheckoutViewController: STPApplePayContextDelegate {
    completion: @escaping StripeApplePay.STPIntentClientSecretCompletionBlock
  ) {
    guard let paymentIntentClientSecret = self.applePayPaymentIntent else {
+      self.viewModel.inputs.checkoutTerminated()


These calls aren't needed - AFAIK everywhere that completion(nil, error) is called will end up below in case: .error of func applePayContext(didCompleteWith:error:). Tested this with a breakpoint and by breaking one of the calls.

Oh, thanks! That makes this nicer :) I wasn't sure how to generate one of these errors so I really appreciate that!

Ha, me neither, but I just set something to nil and checked what happened 😆

* Show processing view while payment is processing * Support rest of payment flow * Test processing view in apple pay flow * Minor edits for clarity and more tests

ifosli added 2 commits April 1, 2024 14:40

Show processing view while payment is processing

20d550c

Support rest of payment flow

3b98789

ifosli added the post-campaign-pledging label Apr 1, 2024

ifosli self-assigned this Apr 1, 2024

Test processing view in apple pay flow

eb0a219

ifosli commented Apr 1, 2024

View reviewed changes

Merge branch 'main' into checkoutVcProcessingView

58f8284

ifosli marked this pull request as ready for review April 1, 2024 22:24

ifosli requested review from amy-at-kickstarter and scottkicks April 1, 2024 22:24

amy-at-kickstarter reviewed Apr 2, 2024

View reviewed changes

amy-at-kickstarter approved these changes Apr 2, 2024

View reviewed changes

Minor edits for clarity and more tests

90cb1ca

ifosli force-pushed the checkoutVcProcessingView branch from 40b5a85 to 90cb1ca Compare April 2, 2024 16:56

Merge branch 'main' into checkoutVcProcessingView

3365f08

scottkicks approved these changes Apr 2, 2024

View reviewed changes

ifosli merged commit ec45e46 into main Apr 2, 2024
5 checks passed

ifosli deleted the checkoutVcProcessingView branch April 2, 2024 18:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MBL-1307] Show processing view while payment is processing #2013

[MBL-1307] Show processing view while payment is processing #2013

ifosli commented Apr 1, 2024 •

edited

ifosli Apr 1, 2024

amy-at-kickstarter Apr 2, 2024

ifosli Apr 2, 2024

amy-at-kickstarter Apr 2, 2024

ifosli Apr 2, 2024

amy-at-kickstarter left a comment

amy-at-kickstarter Apr 2, 2024

amy-at-kickstarter Apr 2, 2024

ifosli Apr 2, 2024

amy-at-kickstarter Apr 2, 2024

amy-at-kickstarter Apr 2, 2024

ifosli Apr 2, 2024

amy-at-kickstarter Apr 2, 2024 •

edited

		@@ -12,11 +12,14 @@ final class PostCampaignCheckoutViewModelTests: XCTestCase {
		Never

[MBL-1307] Show processing view while payment is processing #2013

[MBL-1307] Show processing view while payment is processing #2013

Conversation

ifosli commented Apr 1, 2024 • edited

📲 What

👀 See

✅ Acceptance criteria

⏰ TODO

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amy-at-kickstarter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amy-at-kickstarter Apr 2, 2024 • edited

Choose a reason for hiding this comment

ifosli commented Apr 1, 2024 •

edited

amy-at-kickstarter Apr 2, 2024 •

edited