updates imgix urls with cloudflare ones #2017
Merged
+117
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrenwegs
force-pushed
the
cloudflare-migration
branch
from
37cc2e3
to
d110185
Compare
|
Commit d110185 looks good, but also looks like another commit got pulled in here? Updating with merge to see if that fixes it. |
warrenwegs
force-pushed
the
cloudflare-migration
branch
from
792d182
to
e3c7136
Compare
|
@amy-at-kickstarter I had to redo these replacements so the commit history got a bit mixed up earlier. It's correct now and should just be my commits and main branch merge ins. Not sure why the ios-private repo is failing tests, same changes there. Let me know if there is a trick to it I'm not seeing. |
|
@warrenwegs Ah, don't bother with putting a PR on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Replaces any imgix urls with cloudflare equivalents.
🤔 Why
We are no longer using imgix for serving/transforming images, only cloudflare.
🛠 How
These urls should just work
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
🏎 Performance
✅ Acceptance criteria
⏰ TODO