Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1124] Add tracking for late pledges #2021

Merged
merged 7 commits into from Apr 4, 2024
Merged

[MBL-1124] Add tracking for late pledges #2021

merged 7 commits into from Apr 4, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented Apr 3, 2024

πŸ“² What

Track when the checkout page is viewed and pledge (or apple pay) button is clicked in the late pledge flow. We also add requested late pledge information to the project properties.

πŸ‘€ See

Jira

βœ… Acceptance criteria

  • Segment events are sent in late pledge checkout flow with project_state set to post_campaign
  • Segment events outside the late pledge checkout flow are unchanged except for having one extra property
  • project_late_pledge_enabled is set to true if a project has late pledges enabled, regardless of if it's in the late pledging state or not

@ifosli ifosli marked this pull request as ready for review April 3, 2024 20:21
@ifosli ifosli requested review from a team and scottkicks and removed request for a team April 3, 2024 20:21
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifosli ifosli merged commit 7661516 into main Apr 4, 2024
5 checks passed
@ifosli ifosli deleted the latePledgeAnalytics branch April 4, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants