Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1328] Update Pledge Button Enabled Signals #2022

Merged
merged 3 commits into from Apr 4, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Apr 3, 2024

Pledge Button enabled state needs to rely on successfully creating a new payment intent for pre-existing cards or when a new card is successfully created and selected.

🛠 How

Creates separate inputs for existing and new cards allowing the pledge button to respond to either scenario mentioned above.

👀 See

Simulator Screen Recording - iPhone 15 Pro Max - 2024-04-03 at 14 33 00

✅ Acceptance criteria

  • Processing view doesn't hang when pledging with a new or existing card

@scottkicks scottkicks self-assigned this Apr 3, 2024
@scottkicks scottkicks marked this pull request as ready for review April 3, 2024 20:03
@scottkicks scottkicks requested a review from ifosli April 3, 2024 20:03
@scottkicks scottkicks force-pushed the feat/scott/late-pledge-cta-fix-2 branch from f9e2214 to 7d84082 Compare April 4, 2024 13:37
@scottkicks scottkicks changed the title [MBL-1328] Wait for PaymentIntent Before Enabling Pledge Button [MBL-1328] Update Pledge Button Enabled Signals Apr 4, 2024
@scottkicks scottkicks requested review from ifosli and removed request for ifosli April 4, 2024 15:19
@scottkicks scottkicks merged commit 4b90a3d into main Apr 4, 2024
5 checks passed
@scottkicks scottkicks deleted the feat/scott/late-pledge-cta-fix-2 branch April 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants