MBL-1338: Re-fetch stored cards after login #2023
Merged
+67
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
bug/adyer/MBL-1338/pledge-after-login
branch
from
73864a9
to
b2e95e4
Compare
amy-at-kickstarter
requested review from
a team and
ifosli
and removed request for
a team
ifosli
approved these changes
Apr 4, 2024
amy-at-kickstarter
force-pushed
the
bug/adyer/MBL-1338/pledge-after-login
branch
from
7d83d8e
to
df2b16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Re-fetch stored cards after login.
🤔 Why
If you weren't logged in the first time you accessed the late pledge page, we never fetched your stored cards. This means that, when you tapped on submit, one of the prerequisites was missing and your pledge would never complete.
⏰ TODO
⏫ Follow up
I created a ticket for us to resolve the 500, which is due to where we call Checkout vs. where we call Login.