Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1352] Backfill Tests In PostCampaignViewModel #2025

Merged
merged 3 commits into from Apr 4, 2024

Conversation

scottkicks
Copy link
Contributor

@scottkicks scottkicks commented Apr 4, 2024

πŸ“² What

Adding more test coverage around some outputs

πŸ€” Why

safety is not guaranteed

βœ… Acceptance criteria

  • All tests pass and no UI or UX changes

@scottkicks scottkicks self-assigned this Apr 4, 2024
@scottkicks scottkicks marked this pull request as ready for review April 4, 2024 19:45
@scottkicks scottkicks requested review from a team and amy-at-kickstarter and removed request for a team April 4, 2024 19:45
@scottkicks scottkicks changed the title [MBL-1349] Backfill Tests In PostCampaignViewModel [MBL-1352] Backfill Tests In PostCampaignViewModel Apr 4, 2024
Copy link
Contributor

@amy-at-kickstarter amy-at-kickstarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ love it

@scottkicks scottkicks merged commit d9fb398 into main Apr 4, 2024
4 checks passed
@scottkicks scottkicks deleted the feat/scott/backfill-tests branch April 4, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants