Fix reuseIdentifier for empty message cells #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
changed the title
| @@ -14,7 +14,7 @@ internal final class MessageThreadsDataSource: ValueCellDataSource { | |||
| } | |||
|
|
|||
| internal func emptyState(isVisible: Bool) { | |||
| self.set(cellIdentifiers: isVisible ? ["MessageThreadsEmptyState"] : [], | |||
| self.set(cellIdentifiers: isVisible ? ["MessageThreadEmptyStateCell"] : [], | |||
There was a problem hiding this comment.
Possible to write a test? Also would be nice to throw this in an enum or constant.
There was a problem hiding this comment.
yeah i could write a test. i hate loose strings and would love to have an enum for all of our cell names, but it seems like a separate task?
theginbin
commented
Jul 14, 2017
| @@ -7,14 +7,16 @@ internal final class MessageThreadsDataSource: ValueCellDataSource { | |||
| case messageThreads | |||
| } | |||
|
|
|||
| internal let emptyStateCellIdentifier = String(describing: MessageThreadEmptyStateCell.self) | |||
There was a problem hiding this comment.
hey @stephencelis in lieu of a more standardized way of accessing these loose cell names across the codebase, I opted for this constant. Let me know if this works.
There was a problem hiding this comment.
Sounds good! Wanna make it a static?
stephencelis
approved these changes
Jul 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Was testing something for @tiegz and found a bug where we didn't have the correct reuse identifier for empty Messages cells! Woops. This fixes that as well as points us to
masteronReactiveExtensionswith @stephencelis's latest update.