[MBL-1362] If user cancels adding new card, don't show error banner #2035
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifosli
force-pushed
the
silentlyCancelNewCard
branch
from
7f68409
to
9aed0a0
Compare
ifosli
force-pushed
the
silentlyCancelNewCard
branch
from
9aed0a0
to
99d1597
Compare
ifosli
requested review from
a team and
scottkicks
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
We currently show a "Something went wrong" error banner if a user decides to cancel adding a card through the 3DS prompt. This removes that banner.
Note: "Something went wrong" banner still shows as part of the payment flow if a user uses a saved 3DS card for checkout and cancels there.
👀 See
Jira
✅ Acceptance criteria
Todo