Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1375: Change example data in TwoFactorViewModelTests #2041

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

amy-at-kickstarter
Copy link
Contributor

📲 What

Remove example data that includes a real-looking Kickstarter address and password.

🤔 Why

Reported as possible security leak.

@amy-at-kickstarter amy-at-kickstarter requested review from a team and scottkicks and removed request for a team April 18, 2024 16:43
@amy-at-kickstarter amy-at-kickstarter self-assigned this Apr 18, 2024
@amy-at-kickstarter amy-at-kickstarter marked this pull request as ready for review April 18, 2024 16:43
@@ -228,7 +228,7 @@ final class TwoFactorViewModelTests: TestCase {

withEnvironment(apiService: MockService(resendCodeResponse: error)) {
self.vm.inputs.viewWillAppear()
self.vm.inputs.facebookToken("2934ohhailisa")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@amy-at-kickstarter amy-at-kickstarter merged commit 44ee3fb into main Apr 18, 2024
4 checks passed
@amy-at-kickstarter amy-at-kickstarter deleted the feat/adyer/mbl-1375/remove-gina branch April 18, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants