Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBL-1431] Fix post button compressing #2066

Merged
merged 3 commits into from
May 23, 2024
Merged

[MBL-1431] Fix post button compressing #2066

merged 3 commits into from
May 23, 2024

Conversation

ifosli
Copy link
Contributor

@ifosli ifosli commented May 22, 2024

πŸ“² What

Update the comment "post" button to no longer have a dynamic size by setting compression resistance and content hugging priority to required.

πŸ‘€ See

Jira

Before πŸ› After πŸ¦‹ After Large Text
Simulator Screen Recording - iPhone 15 Pro Max - 2024-05-21 at 14 50 54 Simulator Screen Recording - iPhone 15 Pro Max - 2024-05-21 at 14 59 05 image

♿️ Accessibility

Since I got rid of the max button size in favor of sticking with the content size, I did check what happens for largest accessible size in spanish and the button looks okay

βœ… Acceptance criteria

  • This happens at random, but I also managed to consistently repro by starting to type a comment in the main project comments, opening comment replies and start typing a comment there, navigate back to main project comments to keep typing (and post button disappears). Now it should no longer disappear.
  • Posting experience for large font sizes is no worse

@ifosli ifosli self-assigned this May 22, 2024
@ifosli ifosli changed the title Set hugging priority and compression resistance of post button to req… [MBL-1431] Fix post button compressing May 22, 2024
@ifosli ifosli marked this pull request as ready for review May 22, 2024 19:08
@ifosli ifosli requested review from a team and scottkicks and removed request for a team May 22, 2024 19:08
@ifosli ifosli added the bug label May 22, 2024
Copy link
Contributor

@scottkicks scottkicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ifosli ifosli merged commit 461ae04 into main May 23, 2024
5 checks passed
@ifosli ifosli deleted the postButtonCompression branch May 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants