New backer push navigate to activity #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essageTreads view
…ickstarter/ios-oss into creator_message_notification_1
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
# Conflicts: # Kickstarter-iOS/AppDelegate.swift # Kickstarter-iOS/ViewModels/AppDelegateViewModel.swift # Kickstarter-iOS/Views/Controllers/DashboardViewController.swift # Kickstarter-iOS/Views/Controllers/RootTabBarViewController.swift # Library/Navigation.swift # Library/ViewModels/DashboardViewModel.swift
justinswart
suggested changes
Aug 15, 2017
Kickstarter-iOS/AppDelegate.swift
Outdated
| private func goToProjectActivities(_ projectId: Param) { | ||
| self.rootTabBarController? | ||
| .swithchToProjectActivities(projectId: projectId) | ||
|
|
There was a problem hiding this comment.
You can remove this new line.
Kickstarter-iOS/AppDelegate.swift
Outdated
| @@ -319,6 +325,12 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| .switchToCreatorMessageThread(projectId: projectId, messageThread: messageThread) | |||
| } | |||
|
|
|||
| private func goToProjectActivities(_ projectId: Param) { | |||
| self.rootTabBarController? | |||
| .swithchToProjectActivities(projectId: projectId) | |||
There was a problem hiding this comment.
This should fit on one line and there's a spelling error swithch -> switch.
| public func swithchToProjectActivities(projectId: Param) { | ||
| self.switchToDashboard(project: nil) | ||
|
|
||
| guard let dashboardNav = self.selectedViewController as? UINavigationController, |
There was a problem hiding this comment.
When we do double lets in a guard we like to nest them for readability:
guard
let dashboardNav = self.selectedViewController as? UINavigationController,
let dashboardVC = dashboardNav.viewControllers.first as? DashboardViewController
else {
...
}
| navigateToActivitiesReceived.producer | ||
| .skipNil() | ||
| .filter { $0 == .id(project.id) } | ||
| .map { _ in project } |
There was a problem hiding this comment.
Wonder if this would read better as .mapConst(project) 🤔
There was a problem hiding this comment.
For me personally .map { _ in project } feels more explicit.
| @@ -772,7 +774,7 @@ final class AppDelegateViewModelTests: TestCase { | |||
| launchOptions: [UIApplicationLaunchOptionsKey.remoteNotification: backingForCreatorPushData] | |||
| ) | |||
|
|
|||
| self.goToDashboard.assertValues([param]) | |||
| self.goToProjectActivities.assertValues([param]) | |||
There was a problem hiding this comment.
What happened to the test for goToDashboard?
There was a problem hiding this comment.
We are going to ProjectActivities instead of going to the Dashboard
justinswart
approved these changes
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Clicking on the new backer notification opens activities view for the corresponding project
How
Expanded on the concept used for "Creator message push" functionality:
Added Project activity navigation node
Added navigateToActivities management signals and producers in the DashboardViewModel
See 👀
Trello