Message push with open project view #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essageTreads view
…ickstarter/ios-oss into creator_message_notification_1
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
…tivity # Conflicts: # Library/ViewModels/DashboardViewModel.swift
# Conflicts: # Kickstarter-iOS/AppDelegate.swift # Kickstarter-iOS/ViewModels/AppDelegateViewModel.swift # Kickstarter-iOS/Views/Controllers/DashboardViewController.swift # Kickstarter-iOS/Views/Controllers/RootTabBarViewController.swift # Library/Navigation.swift # Library/ViewModels/DashboardViewModel.swift
# Conflicts: # Kickstarter-iOS/Views/Controllers/RootTabBarViewController.swift
justinswart
approved these changes
Aug 23, 2017
stephencelis
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is to fix a bug that when we have model view open (for example project view) and user clicks on the message push notification - navigation to the message thread happens "behind" the open modal view. As the result user don't see any changes on the screen until modal view is closed
How
To fix this we explicitly close open modal view when navigation happens
See 👀
Trello