Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletters to settings #228

Merged
merged 5 commits into from
Aug 28, 2017
Merged

Add newsletters to settings #228

merged 5 commits into from
Aug 28, 2017

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Aug 24, 2017

What

'Invent' and 'Arts & Culture News' Newsletters were missing from the settings menu. Both are now added.

See πŸ‘€

See screenshots below.

TODO ⏰

  • Strings

Copy link
Contributor

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking real good! Some strings to translate, but otherwise perfect!

@cdolm92
Copy link
Contributor Author

cdolm92 commented Aug 24, 2017

Awesome, thanks! πŸ’ƒ πŸ‘

Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @cdolm92!

@cdolm92 cdolm92 merged commit 486b460 into master Aug 28, 2017
@cdolm92 cdolm92 deleted the add-newsletters-to-settings branch August 28, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants