Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that makes spinner persist on reward drill-in #240

Merged
merged 5 commits into from
Sep 12, 2017

Conversation

Scollaco
Copy link
Contributor

What

Fixed bug on which activity indicator wouldn't disappear from RewardPledgeViewController.

Why

https://trello.com/c/iwWkq5Gd/117-spinner-persists-on-reward-drill-in.

See 馃憖

screenbug

Scollaco and others added 5 commits September 12, 2017 17:21
# Conflicts:
#	Screenshots/_64/Kickstarter_Framework_iOSTests.RewardPledgeViewControllerTests/testChangeReward_lang_ja_apple_pay_false@2x.png
#	Screenshots/_64/Kickstarter_Framework_iOSTests.RewardPledgeViewControllerTests/testChangeReward_lang_ja_apple_pay_true@2x.png
#	Screenshots/_64/Kickstarter_Framework_iOSTests.RewardPledgeViewControllerTests/testManageReward_lang_ja@2x.png
#	Screenshots/_64/Kickstarter_Framework_iOSTests.RewardPledgeViewControllerTests/testPledge_lang_ja_apple_pay_false@2x.png
#	Screenshots/_64/Kickstarter_Framework_iOSTests.RewardPledgeViewControllerTests/testPledge_lang_ja_apple_pay_true@2x.png
@justinswart
Copy link
Contributor

@Scollaco merging this in so we can get the bugfixes out 馃憤

@justinswart justinswart merged commit ce8c177 into master Sep 12, 2017
@justinswart justinswart deleted the bug-fix-loading-on-pledge-view branch September 12, 2017 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants