Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Email Unverified Email state UX tweak #632

Merged
merged 4 commits into from Mar 20, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Mar 7, 2019

📲 What

Small UX improvement that prevents the user's email fields from being refreshed when the user's change email request is submitted. This means that they won't see the This email is unverified label until after they leave the screen and come back to it.

🤔 Why

We decided in combination with Design that this was a better user experience.

✅ Acceptance criteria

  • Test Case One Below:
  1. Log in on an account with a verified email address. Navigate to change email screen. You should not see the "This email address is unverified" label or the "Send Verification Email" button.
  2. Change your email. You should see the "Got it, your changes have been saved" success banner. You should not see the "This email address is unverified" label or the "Send Verification Email" button.
  3. Navigate back to "Account". You should see the red warning icon in the "Change Email" row.
  4. Tap "Change Email" to navigate to the Change Email screen. You should see the "This email address is unverified" label and the "Send Verification Email" button.
  • Test Case Two Below:
  1. Log in on an account with an unverified email address. Navigate to change email screen. You should see the "This email address is unverified" label and the "Send Verification Email" button.
  2. Change your email. You should see the "Got it, your changes have been saved" success banner. You should still see the "This email address is unverified" label and the "Send Verification Email" button.

@ifbarrera
Copy link
Contributor Author

Copy link
Contributor

@Scollaco Scollaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ifbarrera 👍

@ifbarrera ifbarrera merged commit cf52da7 into master Mar 20, 2019
@ifbarrera ifbarrera deleted the change-email-resend-verification-tweak branch March 20, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants