👩🔬 [Investment Day] Remove unused code #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusi
commented
Mar 28, 2019
| @@ -35,8 +35,6 @@ final class CreatePasswordViewController: UIViewController, MessageBannerViewCon | |||
| |> \.rightBarButtonItem .~ UIBarButtonItem(customView: self.saveButtonView) | |||
|
|
|||
| if let childView = self.createPasswordTableViewController.tableView { | |||
| childView.translatesAutoresizingMaskIntoConstraints = false | |||
There was a problem hiding this comment.
This is done internally inside of childView.constrainEdges(to: self.view)
dusi
commented
Mar 28, 2019
| @testable import Kickstarter_Framework | ||
| import XCTest | ||
|
|
||
| final class CreatePasswordViewControllerTests: XCTestCase { |
There was a problem hiding this comment.
We should probably test this just to be sure controller containment doesn't break in the future.
dusi
force-pushed
the
remove-unused-code
branch
from
64416e9
to
edbb161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Removes unused files.
🤔 Why
During my work on #645 I've noticed that there are couple files that are unused in our project so I've decided to remove these.
✅ Acceptance criteria