Comment digest notification settings #657
Conversation
…comment-digest-notification-settings
…comment-digest-notification-settings
…comment-digest-notification-settings
| @@ -55,6 +55,7 @@ public struct User { | |||
| public struct Notifications { | |||
| public private(set) var backings: Bool? | |||
| public private(set) var comments: Bool? | |||
| public private(set) var commentReplies: Bool? | |||
There was a problem hiding this comment.
Is our intent to order these alphabetically? If that's the case shouldn't commentReplies come before comments?
There was a problem hiding this comment.
This would probably apply to this whole PR 😭
| @@ -214,6 +215,7 @@ extension User.Notifications: Argo.Decodable { | |||
| let tmp1 = curry(User.Notifications.init) | |||
| <^> json <|? "notify_of_backings" | |||
| <*> json <|? "notify_of_comments" | |||
| <*> json <|? "notify_of_comment_replies" | |||
There was a problem hiding this comment.
Should this be tested in UserTests?
| @@ -249,6 +250,9 @@ extension SettingsNotificationCellViewModel { | |||
| case .friendBacksProject: | |||
| return notificationType == .email | |||
| ? UserAttribute.Notification.friendActivity : UserAttribute.Notification.mobileFriendActivity | |||
| case .commentReplyDigest: | |||
There was a problem hiding this comment.
Should we also test this case?
There was a problem hiding this comment.
I don't think it's necessary because the notifications test that we have already are sufficient.
|
QAing this PR I've noticed the following issue...please correct me if I'm doing something wrong but it looks like in order to see changes ( Steps to reproduce:
It appears to me that we're either not reloading the table properly or not refreshing for some reason. |
| @@ -25,6 +25,7 @@ public enum UserAttribute { | |||
| case let .notification(notification): | |||
| switch notification { | |||
| case .comments: return \.notifications.comments | |||
| case .commentReplies: return \.notifications.commentReplies | |||
There was a problem hiding this comment.
Let's also move this above comments in order to sort alphabetically
| @@ -52,6 +53,7 @@ public enum UserAttribute { | |||
|
|
|||
| public enum Notification { | |||
| case comments | |||
| case commentReplies | |||
| @@ -71,6 +73,7 @@ public enum UserAttribute { | |||
| public var trackingString: String { | |||
| switch self { | |||
| case .comments, .mobileComments: return "New comments" | |||
| case .commentReplies: return "Comment reply digest" | |||
| @@ -209,6 +209,7 @@ extension SettingsNotificationCellViewModel { | |||
| AppEnvironment.current.koala.trackChangePushNotification(type: notification.trackingString, | |||
| on: enabled) | |||
| case .comments, | |||
| .commentReplies, | |||
📲 What
This PR implements comment digest notification in settings, which allows the user(backers and creators) to opt in/out of email notifications.
This PR also fixes the issue of users currently not being able to update their notifications.
🤔 Why
Currently, backers have no way of knowing if their question was answered or post was responded to without coming back to the project and looking. Creators receive an individual email for every comment and comment reply on their project. Now, comment digest is for all users.
👀 See
Trello, screenshots, external resources?
✅ Acceptance criteria
Test Creator Reply Digest
Settings > NotificationsScroll down toComment reply digesttoggle the email notificationTest Settings Notifications
Settings > Notificationsstart toggling email and push notificationsProject Activity notification toggles do not reflect the apps(iOS and Android) on web. This PR does not fix this issue