Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Facebook event and advertiser ID collection flags #713

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

justinswart
Copy link
Contributor

📲 What

Sets FacebookAutoLogAppEventsEnabled and FacebookAdvertiserIDCollectionEnabled to false in our Info.plist.

🤔 Why

We want Facebook's SDK doing as little as possible in our app, currently we only use it as a convenience for people to sign in and we do not want it logging anything or trying to use our app's advertising identifier.

🛠 How

Set the flags in the plist.

👀 See

https://developers.facebook.com/docs/app-events/getting-started-app-events-ios/#auto-events

Copy link
Contributor

@ifbarrera ifbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I'm seeing this warning in the console though:

image

Tried adding the following settings:

    Settings.isAutoLogAppEventsEnabled = false
    Settings.isAdvertiserIDCollectionEnabled = false
    Settings.shouldLimitEventAndDataUsage = true

... but the warning persisted 🤷‍♀

Of these, I still think it might be worth adding Settings.shouldLimitEventAndDataUsage = true which the docs describe as Whether data such as that generated through FBSDKAppEvents and sent to Facebook should be restricted from being used for other than analytics and conversions. Defaults to NO. This value is stored on the device and persists across app launches.

@justinswart justinswart merged commit 1062a97 into master Jun 20, 2019
@justinswart justinswart deleted the facebook-flags branch June 20, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants