Estimated delivery metadata #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theginbin
suggested changes
Feb 2, 2017
| @@ -116,6 +126,16 @@ internal final class RewardCell: UITableViewCell, ValueCell { | |||
| |> UILabel.lens.textColor .~ .ksr_text_navy_500 | |||
| |> UILabel.lens.numberOfLines .~ 0 | |||
|
|
|||
| _ = self.estimatedDeliveryLabel | |||
| |> UILabel.lens.text %~ { _ in | |||
| localizedString(key: "Estimated_delivery", defaultValue: "Estimated delivery:") } | |||
There was a problem hiding this comment.
can swap this with the Strings version of this string.
Library/Strings.swift
Outdated
| @@ -8330,7 +8330,7 @@ catch your eye?" | |||
| /** | |||
| "%{backers_count} backers total, %{percent_funded} funded, %{time_left} to go" | |||
|
|
|||
| - **es**: "De momento tiene %{backers_count} patrocinadores, financiado al %{percent_funded}, tiempo restante: %{time_left}" | |||
| - **es**: "De momento tiene %{backers_count} patrocinadorefs, financiado al %{percent_funded}, tiempo restante: %{time_left}" | |||
There was a problem hiding this comment.
this looks like an accident. you should revert this change. this file is generated automatically.
| || userIsBacking(reward: reward, inProject: project) | ||
| .map { project, reward in | ||
| reward.remaining != 0 | ||
| || userIsBacking(reward: reward, inProject: project) |
There was a problem hiding this comment.
i think you could set this spacing back to what it was?
justinswart
reviewed
Feb 3, 2017
| @@ -15,6 +15,10 @@ internal final class BackingViewController: UIViewController { | |||
| @IBOutlet fileprivate weak var backerSequenceLabel: UILabel! | |||
| @IBOutlet fileprivate weak var backerShippingAmountLabel: UILabel! | |||
| @IBOutlet fileprivate weak var backerShippingDescriptionLabel: UILabel! | |||
| @IBOutlet fileprivate weak var estimatedDeliveryDateLabel: UILabel! | |||
| @IBOutlet fileprivate weak var estimatedDeliveryLabel: UILabel! | |||
| @IBOutlet fileprivate weak var estimatedDeliverySeperatorView: UIView! | |||
There was a problem hiding this comment.
Spotted a couple misspellings of separator.
| self.vm.inputs.viewDidLoad() | ||
|
|
||
| self.estimatedDeliveryDateLabelText.assertValues(["July 2016"], | ||
| "Emits estimated delivery date") |
There was a problem hiding this comment.
I think the comment should be in line with the first argument:
self.estimatedDeliveryDateLabelText.assertValues(["July 2016"],
"Emits estimated delivery date")
|
@kickstarter/native-squad g2g? |
theginbin
approved these changes
Feb 6, 2017
mbrandonw
approved these changes
Feb 7, 2017
|
Gonna merge this is cause realize the strings updated and so we'll get screenshot failures in other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Estimated delivery metadata now appears in Reward Cells and Backing Screen.
Reward Cell
Backing Screen
