Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dSYMs upload bug #730

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Fix dSYMs upload bug #730

merged 1 commit into from
Jul 2, 2019

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Jun 28, 2019

πŸ“² What

Fixes an issue in that our dSYMs were silently failing to upload to Fabric/Crashlytics.

πŸ€” Why

tl;dr - We enjoy de-symbolicating stuff.

iOS crash logs only show symbols (memory addresses) in their stack traces unless these files are provided which allows Fabric to de-symbolicate them so that they are legible to mere mortals such as us.

πŸ›  How

Updated:

  • Fastlane -> 2.126.0.
  • aws_s3 Fastlane plugin -> 1.6.0 (it kept warning about this).
  • Fabric -> 3.13.2.
    • This included a newer upload-symbols binary which appears to be where the change crept in. We keep this binary in our bin directory and it appears that the newer version of this handles an API change which was causing ours to break. An added benefit is that this file is significantly smaller than the previous binary πŸ€·β€β™‚

References:

fastlane/fastlane#14140
fastlane/fastlane#13096
https://docs.fastlane.tools/actions/upload_symbols_to_crashlytics/ (binary_path).

πŸ‘€ See

Before πŸ› After πŸ¦‹
Screen Shot 2019-06-28 at 10 39 58 AM Screen Shot 2019-06-28 at 10 40 11 AM

βœ… Acceptance criteria

  • Uploads dSYMs without the Shell command exited with exit status 8 instead of 0. error (see steps below).

You can test this locally by doing the follow:

make fabric #just to ensure the SDK is updated
bundle install #should update fastlane
bundle exec fastlane match_appstore
agvtool new-version -all $(($(date +%s)/100))
bundle exec fastlane itunes_gym
FABRIC_API_KEY=<api_key> bundle exec fastlane upload_dsyms #first make upload_dsyms lane public in Fastfile

^ Find the API KEY here: https://fabric.io/settings/organizations/ (select the production app, API key at the top).

@justinswart
Copy link
Contributor Author

@justinswart justinswart merged commit 1b74850 into master Jul 2, 2019
@justinswart justinswart deleted the fix-dsym-upload branch July 2, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants