🐞 [Bug] UIPageViewController crash fix #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
force-pushed
the
pageviewcontroller-crash-fix
branch
from
fc9bdd4
to
226ae7f
Compare
ifbarrera
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Attempts to fix an escalating crash that we've been seeing in our crash reports which appear to be linked to
setViewControllersbeing called during a page transition. Although I have not been able to reproduce this crash myself, this is my suggested fix which I'd like to ship with the next release to see if it brings the reported crashes down.🤔 Why
This crash has been rising in our crash reports (link below).
🛠 How
ksr_setViewControllersextention toUIPageViewControllerwhich ensures this is always executed on the main thread.👀 See
https://fabric.io/kickstarter2/ios/apps/com.kickstarter.kickstarter/issues/5b8409046007d59fcdf6275f?time=last-seven-days
https://stackoverflow.com/questions/25740245/assertion-failure-in-uipageviewcontroller
✅ Acceptance criteria