Live stream subscription state refresh #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Feb 9, 2017
| internal func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) | ||
| -> SignalProducer<Bool, LiveApiError> { | ||
| internal func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) -> SignalProducer< | ||
| LiveStreamSubscribeEnvelope, LiveApiError> { |
There was a problem hiding this comment.
let's keep the type SignalProducer<LiveStreamSubscribeEnvelope, LiveApiError> all on one line
| @@ -31,5 +31,6 @@ public protocol LiveStreamServiceProtocol { | |||
| func signInAnonymously(completion: @escaping (String) -> Void) | |||
|
|
|||
| /// Subscribes/unsubscribes a user to an event. | |||
| func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) -> SignalProducer<Bool, LiveApiError> | |||
| func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) -> SignalProducer<LiveStreamSubscribeEnvelope, | |||
| LiveApiError> | |||
| @@ -160,7 +160,8 @@ public struct LiveStreamService: LiveStreamServiceProtocol { | |||
| } | |||
| } | |||
|
|
|||
| public func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) -> SignalProducer<Bool, LiveApiError> { | |||
| public func subscribeTo(eventId: Int, uid: Int, isSubscribed: Bool) -> SignalProducer< | |||
| LiveStreamSubscribeEnvelope, LiveApiError> { | |||
| XCTAssertEqual(true, eventsEnvelope.value?.success) | ||
| } | ||
|
|
||
| func testParseJson_Failure() { |
There was a problem hiding this comment.
nice thanks for covering all the cases
| public enum lens { | ||
| public static let success = Lens<LiveStreamSubscribeEnvelope, Bool>( | ||
| view: { $0.success }, | ||
| set: { var new = $1; new.success = $0; return new } |
There was a problem hiding this comment.
yahhhh big fan of these lenses now
| .fetchEvent(eventId: event.id, uid: AppEnvironment.current.currentUser?.id) | ||
| .ksr_delay(AppEnvironment.current.apiDelayInterval, on: AppEnvironment.current.scheduler) | ||
| .materialize() | ||
| }.take(first: 1) |
There was a problem hiding this comment.
i don't think the take(first: 1) is needed since this can only emit a single time
There was a problem hiding this comment.
you can also prefix(value: event) in the switchMap, and then the signal below just becomes let event = updatedEventFetch.values()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I merged #63 some behaviour was changed regarding how the
LiveStreamEventis configured on theLiveStreamEventDetailsViewModelwhich emits the subscription state for that live stream. Because the change meant that the view model is configured with theLiveStreamEventthat is fetched on the project page, it didn't contain any subscription info. This also wasn't immediately apparent because we didn't have great error handling around the subscribe call. In the past we would receive a200but thesuccessvalue in the JSON wasfalse. Now we check for that.This fixes all of that:
LiveStreamSubscribeEnvelopeso that the response from the subscribe call is a real thing.LiveStreamEventon load to get the latest subscription status.