Rewards Collection View Footer #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
reviewed
Aug 8, 2019
There was a problem hiding this comment.
Looking pretty legit! Did an first pass on the code and had some minor comments.
Unfortunately this does also make the transition look a little weird for long rewards, but we can fix that separately, it's also looking a little strange since the gradient was added 🤦♂ All those things need to be accounted for during the animation.
| self.viewModel.outputs.configureRewardsCollectionViewFooterWithCount | ||
| .observeForUI() | ||
| .observeValues { [weak self] count in | ||
| self?.updateRewardsCollectionFooterView(with: count) |
There was a problem hiding this comment.
Could we match this function name to the output name? Just for consistency and easier to find things.
Kickstarter-iOS/Views/Controllers/RewardsCollectionViewFooter.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Adds a footer below the rewards collection view that shows the total number of rewards.
🤔 Why
To help users orient themselves within the rewards browsing experience.
🛠 How
My first instinct was to try to use
supplementaryViews which come for free withUICollectionView. Unfortunately though I quickly realized that this wouldn't work becauseUICollectionViewonly supportssectionfooter/header "supplementary" views - because we have a horizontally scrolling collection view, it was then showing the footer at the "end" of the section of rewards, which is basically on the right side of the last reward. This wasn't want we wanted.The current approach is to add a footer view as a subview of the
RewardCollectionViewController'sview. The footer view is configured with the number of rewards to display, and is shown/hidden depending on whether the currenttraitCollection.verticalSizeClassis.regularor.compact.👀 See
Trello, screenshots, external resources?
iPhone Landscape:
♿️ Accessibility
🏎 Performance
✅ Acceptance criteria
On iPhone 5, 6, 7, 8, X
On iPhone XS max, iPad
⏰ TODO