Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 10.3 updates #797

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Xcode 10.3 updates #797

merged 2 commits into from
Aug 13, 2019

Conversation

justinswart
Copy link
Contributor

@justinswart justinswart commented Aug 13, 2019 •
edited by dusi
Loading

📲 What

  • Updates CircleCI to use Xcode 10.3 and iOS 12.4.
  • Sets the latest version check flag in the project file to Xcode 10.3.

🤔 Why

  • Good to have our CI running the same version that we're using locally.
  • Silences the warning that everyone is likely to get that they need to update to the latest project settings.

👀 See

https://developer.apple.com/documentation/xcode_release_notes/xcode_10_3_release_notes

✅ Acceptance criteria

  • Everything passes on CircleCI.

@justinswart justinswart requested a review from dusi August 13, 2019 17:28
dusi
dusi approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢
🚢 🚢 🚢
🚢 🚢 🚢

@justinswart justinswart merged commit 92440f6 into master Aug 13, 2019
@justinswart justinswart deleted the xcode-10.3 branch August 13, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusi dusi dusi approved these changes

Assignees

@dusi dusi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justinswart @dusi