Refresh live streams on project page appearing #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Feb 8, 2017
| let liveStreamEventsFetch = Signal.merge( | ||
| project.take(first: 1), | ||
| projectWhenViewAppears | ||
| ) |
There was a problem hiding this comment.
nice nice! i think you could even just inline this without the intermediate signal:
let liveStreamEventsFetch = project
.take(first: 1)
.takeWhen(self.viewWillAppearAnimated.signal)
.switchMap { ...There was a problem hiding this comment.
Oh, wouldn't that take(first: 1) cause the signal to complete?
There was a problem hiding this comment.
when the source completes, the whole thing completes. i always forget about that. i kinda think the correct behavior is to not complete, but don't wanna open that can of worms now.
you could still inline with this:
let liveStreamEventsFetch = Signal.combineLatest(
project.take(first: 1)
self.viewWillAppearAnimated.signal
)
.switchMap { ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for refreshing a project's live streams when the project page appears.
Alternatively we could be more specific about only doing this when dismissing a live stream/replay but it would require more delegate calls etc due to the nested nature of the project page and the fact that live streams are launched on
ProjectPamphletContentViewControllerand fetched inProjectPamphletViewModel.Perhaps worth doing that though?