Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] message banner hierarchy and rewards card size on smaller screens #803

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Aug 15, 2019

πŸ“² What

Fixes two small bugs:

  • a bug where the message banner was being presented below other view's added on the PledgeViewController
  • bug where the width of the RewardCell is awkwardly large on small (SE) screens

πŸ€” Why

Polish & fixes.

πŸ›  How

  • guarantee that the MessageBanner is brought to to the front before it's displayed
  • add some special logic to reduce the width of the RewardCell for screens with smaller bounds

πŸ‘€ See

Simulator Screen Shot - iPhone 5s - 2019-08-15 at 17 29 14

uKm57jKI6W

βœ… Acceptance criteria

  • Logged in, make sure you have the Native Checkout Pledge View feature flag turned ON, navigate to any project. Turn off your internet (you can do this by turning airplane mode on your device to ON). Then, select any reward.
    PASS You should not see any cards loaded in. Then, after a few seconds, you should see an error banner appear with the message "Something went wrong".
  • on iPhone SE, with the "Native Checkout" feature flag turned ON navigate to the Rewards screen. Verify that the first reward is fully visible within the bounds of the screen.

@ifbarrera ifbarrera requested a review from dusi August 16, 2019 16:35
Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚒 🚒 🚒
🚒 🚒 🚒
🚒 🚒 🚒

@ifbarrera ifbarrera merged commit 2eb896e into master Aug 16, 2019
@ifbarrera ifbarrera deleted the error-banner-pledge-screen branch August 16, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants