Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View backing when project has ended #804

Merged
merged 6 commits into from
Aug 16, 2019
Merged

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Aug 16, 2019

📲 What

This PR fixes two issues:

  • users were previously able to navigate to the pledge screen on non-live projects
  • users trying to view their pledge on a successful project were instead taken to the update pledge screen

Now, users viewing a project they did not back will not be able to tap rewards if the project has ended. Users who have backed a project and tap "View your pledge" are correctly taken to the "View pledge" screen.

🛠 How

More in-depth discussion of the change or implementation.

👀 See

Viewing project that has ended Viewing Backed project that has ended
6jfODEoaK5 xtwL5ospjc

✅ Acceptance criteria

Viewing project that has ended

  • With the Native Checkout feature flag turned ON, browse through discovery and find a project that is either Funding Successful or Funding Unsuccessful. Tap "View rewards".
    AC On the rewards carousel, you should not be able to select/tap any of the rewards.

Viewing project you backed that has ended

  • With the Native Checkout feature flag turned ON, log in and go to your backed projects. Tap on a project with tag Successful or Unsuccessful or Cancelled. Tap "View your pledge".
    AC On the rewards carousel, you should not be able to select/tap any of the rewards that do not have the View your pledge button. On the reward you backed, you should see the View your pledge button, and tapping it should take you to the "View pledge" screen.

@ifbarrera ifbarrera marked this pull request as ready for review August 16, 2019 20:19
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -73,10 +74,27 @@ public final class RewardsCollectionViewModel: RewardsCollectionViewModelType,
selectedRewardFromId,
refTag
)
.filter { arg in
let (project, _, _) = arg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably did this to help the compiler but i'm sure it'll also compile as .filter { project, _, _ in ... }

@ifbarrera ifbarrera merged commit de527c6 into master Aug 16, 2019
@ifbarrera ifbarrera deleted the view-backing-project-ended branch August 16, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants