Refreshing of the Live Stream Discovery view #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
suggested changes
Feb 8, 2017
| @@ -13,6 +16,9 @@ public protocol LiveStreamDiscoveryViewModelInputs { | |||
|
|
|||
| /// Call when the view loads. | |||
| func viewDidLoad() | |||
|
|
|||
| /// Call when the viewWillAppear | |||
| func viewWillAppear() | |||
There was a problem hiding this comment.
does viewWillAppear not get called again when bringing to the foreground?
There was a problem hiding this comment.
Nope, I tried doing it with just that - turns out it's not called.
| .flatMap { _ in | ||
| let periodicRefresh = self.viewDidLoadProperty.signal.switchMap { | ||
| timer(interval: .seconds(60*5), on: AppEnvironment.current.scheduler) | ||
| } |
There was a problem hiding this comment.
i kinda think we don't need this countdown. it would only be useful if the person sat on this page for 5 mins. otherwise navigating away and back should trigger the view will appear.
| @@ -30,6 +30,14 @@ internal final class LiveStreamDiscoveryViewController: UITableViewController { | |||
| internal override func bindViewModel() { | |||
| super.bindViewModel() | |||
|
|
|||
| NotificationCenter.default.addObserver( | |||
| forName: NSNotification.Name.UIApplicationWillEnterForeground, object: nil, | |||
| queue: nil) { [weak self ]_ in | |||
There was a problem hiding this comment.
the newline placement is a little off, could we try something like
NotificationCenter.default
.addObserver(forName: .UIApplicationWillEnterForeground, object: nil, queue: nil) { [weak self ] _ in
self?.viewModel.inputs.appWillEnterForeground()
}There was a problem hiding this comment.
ah yeah that does look a little weird, cool!
mbrandonw
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of different ways that the Live Stream Discovery view will be refreshed to avoid navigating back and seeing 'stale' cards that are perhaps no longer live and now in replay, or were upcoming and are now live, etc.
It will refresh the following ways:
isActiveis set totrue(causes a fetch as before)isActiveis set tofalse(clears data source as before)All of these will only emit when
isActiveistrue.Having done all of this I'm now no longer sure if this is really what we want, it feels like there are just so many ways that this view can be refreshed, but it's done and seems to work fine so let me know what you think!