Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook button image padding #811

Merged
merged 9 commits into from
Aug 22, 2019
Merged

Facebook button image padding #811

merged 9 commits into from
Aug 22, 2019

Conversation

cdolm92
Copy link
Contributor

@cdolm92 cdolm92 commented Aug 21, 2019 •
edited
Loading

📲 What

This PR fixes missing padding between the facebook icon and text in the Facebook Follow button for certain languages

🛠 How

Introduced fbFollowButtonStyle which adds padding between the icon and the text in the facebook button

👀 See

Check out snapshots.

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

✅ Acceptance criteria

  • Look at snapshots, make sure there is padding between icon and text in the Facebook Button

@cdolm92 cdolm92 changed the title new facebook button style, updated snapshots Facebook button image padding Aug 21, 2019
@cdolm92 cdolm92 marked this pull request as ready for review August 21, 2019 21:40
justinswart
justinswart approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@justinswart justinswart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! please run bin/format.sh . to clear up the formatting warning before merging 👍

@cdolm92 cdolm92 merged commit 7c65ae4 into master Aug 22, 2019
@cdolm92 cdolm92 deleted the facebook-button-icon-fix branch August 22, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinswart justinswart justinswart approved these changes

Assignees

@justinswart justinswart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdolm92 @justinswart