Add Ships to: prefix for shipping summary pill #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinswart
commented
Aug 22, 2019
| return shippingSummary | ||
| return localizedString( | ||
| key: "Ships_to_shipping_summary", | ||
| defaultValue: "Ships to: %{shipping_summary}", |
There was a problem hiding this comment.
Related PR is open: https://github.com/kickstarter/kickstarter/pull/16986
ifbarrera
reviewed
Aug 22, 2019
ifbarrera
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Prefixes the non-localized summary string that we get back from the API with "Ships to:".
🤔 Why
We're working on improving the way that we show the shipping summary on the reward cell, this is an interim measure to make the messaging a little clearer on this pill.
🛠 How
👀 See
✅ Acceptance criteria
Ships to:prefix.