Checkout event improvements #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifbarrera
reviewed
Aug 22, 2019
Library/Koala/KoalaTests.swift
Outdated
| @@ -475,7 +475,7 @@ final class KoalaTests: TestCase { | |||
|
|
|||
| let koala = Koala(client: client, loggedInUser: loggedInUser) | |||
|
|
|||
| koala.trackBackThisButtonClicked(project: project, screen: .projectPage) | |||
| koala.trackBackThisButtonClicked(stateType: .pledge, project: project, screen: .projectPage) | |||
There was a problem hiding this comment.
Can we add tests for the other cases of PledgeStateCTAType?
| @@ -167,4 +169,19 @@ internal final class PledgeCTAContainerViewViewModelTests: TestCase { | |||
| self.vm.inputs.configureWith(value: (.right(.couldNotParseJSON), false)) | |||
| self.pledgeRetryButtonIsHidden.assertValues([true, false]) | |||
| } | |||
|
|
|||
| func testNotifyDelegateCTATapped() { | |||
There was a problem hiding this comment.
Can we add a test to verify that tapping the button triggers the events in Koala?
ifbarrera
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Improvements to monitoring user behavior for v1 checkout.
🤔 Why
We now have events for:
Select Reward Button ClickedManage Pledge Button ClickedView Rewards Button ClickedView Your Pledge Button ClickedFix Pledge Button ClickedWe also renamed
Project Page Viewedevent toProject Page✅ Acceptance criteria
KOALA_TRACKINGenvironment variable in the scheme. Then launch the app and navigate to a project. You should see theBack this projectCTA, tap it. You should see an event -"Back this Project Button Clicked"in the console.ManageCTA, tap it. You should see an event"Manage Pledge Button Clicked"in the console.View Your PledgeCTA, tap it. You should see an event"View your pledge Button Clicked"in the console.View rewardsCTA, tap it. You should see an event"View Your Pledge Button Clicked"in the console.