Set koala's base url based on current environment #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusi
commented
Aug 28, 2019
| case .production: | ||
| return Secrets.KoalaEndpoint.production | ||
| } | ||
| fileprivate var base: String { |
There was a problem hiding this comment.
Since our base url is being affected by environmentType we no longer require a separate Endpoint enum.
dusi
commented
Aug 28, 2019
| fileprivate var base: String { | ||
| switch AppEnvironment.current.environmentType { | ||
| case .production: | ||
| return Secrets.KoalaEndpoint.production |
There was a problem hiding this comment.
Only production will go to production ... anything else (development or local) should default to staging
dusi
commented
Aug 28, 2019
| @@ -130,7 +123,7 @@ public final class KoalaTrackingClient: TrackingClientType { | |||
| if dataString.count >= 10_000 { | |||
| print("🐨 [Koala Error]: Base64 payload is longer than 10,000 characters.") | |||
| } | |||
| return URL(string: "\(self.endpoint.base)?data=\(dataString)") | |||
| return URL(string: "\(self.base)?data=\(dataString)") | |||
There was a problem hiding this comment.
Unfortunately KoalaClient isn't very testable (most if not all functions are fileprivate) so I'd suggest we proceed without tests for now (as I wasn't able to figure out how to test)...open to any suggestions!!!
Scollaco
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Tracking events are send to the right Koala endpoint based on current environment.
🤔 Why
We ran into an issue where all tracking events were being sent to production environment. We would like to set the Koala endpoint based on current environment.
🛠 How
See the code change
✅ Acceptance criteria
Release build
Charlesproxyormitmproxy(there are instructions in Guru how to do this)Releasemode by following these instructionsproductionendpoint (this value is accessible inSecrets.KoalaEndpoint.productionEnvironmentDebug build (Alpha, Beta, Debug)
Charlesproxyormitmproxy(there are instructions in Guru how to do this)DebugmodeKOALA_TRACKINGenvironment variable is turnedONby following these instructionsEnvironmenttoStaging(in Beta tools) tracking events are being sent tostagingendpoint (this value is accessible inSecrets.KkoalaEndpoint.staging)EnvironmenttoProduction(in Beta tools) tracking events are being sent toproductionendpoint (this value is accessible inSecrets.KkoalaEndpoint.production)EnvironmentPlease note that if you're immediately not seeing any events you can background the app which should flush the queue.