View pledge screen #826

Scollaco · 2019-09-03T20:59:49Z

📲 What

Adds the ManagePledgeViewController to the Native Checkout flow.

🤔 Why

This is a screen that will allow users to manage and view their pledge. For now, this screen is empty and was created so the team can work on different screens that are part of the manage pledge flow, such as Cancel Pledge, Manage Pledge, Contact creator...

JIRA ticket

🛠 How

By adding ManagePledgeViewController and its view model
Adding logic to present the screen only if the featureNativeCheckoutPledgeView feature flag is enabled.
. If this is not the case, the DeprecatedRewardPledgeViewController will be presented.

👀 See

✅ Acceptance criteria

With `featureNativeCheckoutPledgeView` enabled.

On the Rewards Carousel screen:

Select a reward by tapping the Select button. The PledgeViewController should be presented.
Select a reward of a backed and live project by tapping the Manage your pledge button. The ManagePledgeViewController (blank) should be presented.
Select a different reward of a backed and live project by tapping the Select this reward instead button. The PledgeViewController should be presented.
Selected a backed and ended project. Tap View your pledge and the old BackingViewController should be presented (The logic to go to the new view pledge screen is not implemented in this PR).

With `featureNativeCheckoutPledgeView` disabled.

On the Rewards Carousel screen:

Select a reward by tapping the Select button. The DeprecatedRewardPledgeViewController should be presented.
Select a reward of a backed and live project by tapping the Manage your pledge button. The DeprecatedRewardPledgeViewController should be presented.
Select a different reward of a backed and live project by tapping the Select this reward instead button. The DeprecatedRewardPledgeViewController should be presented.
Selected a backed and ended project. Tap View your pledge and the BackingViewController should be presented.

dusi

ACs check out...I had bunch of suggestions / questions.

Also is it intentional that the navigation bar and the view background color is different? (see screenshot)

dusi · 2019-09-03T21:54:57Z

Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift

+
+  private lazy var editButton: UIBarButtonItem = {
+    UIBarButtonItem(
+      barButtonSystemItem: .edit,


Nino, we didn't have image resources to show the More button (3 dots)?

We don't. Android has it because it's native, not a resource.

Can't we just get PDF from Abstract?

Let me know if you'd want me to extract it ... I should have a copy of Sketch on my machine

Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift

dusi · 2019-09-03T22:27:12Z

Kickstarter-iOS/Views/Controllers/RewardsCollectionViewController.swift

+    let nav = UINavigationController(rootViewController: managePledgeViewController)
+      |> \.modalPresentationStyle .~ .formSheet
+
+    self.present(nav, animated: true, completion: nil)


Again, we can omit completion to have less code.

dusi · 2019-09-03T22:31:22Z

Library/ViewModels/ManagePledgeViewModel.swift

@@ -0,0 +1,28 @@
+import KsApi


Would be cool to also prepare ManagePledgeViewModelTests.swift

dusi · 2019-09-03T22:31:36Z

Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.swift

@@ -0,0 +1,77 @@
+import KsApi


Would be cool to also prepare ManagePledgeViewControllerTests.swift

dusi · 2019-09-03T22:37:08Z

Library/ViewModels/RewardsCollectionViewModel.swift

+    .filter { project, reward, _ -> Bool in
+      project.state == .live && userIsBacking(reward: reward, inProject: project)
+    }
+    .map { project, reward, refTag in


We can't do this point free, correct?

It didn't compile. Maybe because the point free syntax doesn't apply for constructors.

Stupid Swift

dusi · 2019-09-03T22:48:44Z

Library/ViewModels/RewardsCollectionViewModelTests.swift

@@ -157,6 +163,131 @@ final class RewardsCollectionViewModelTests: TestCase {
    XCTAssertEqual(self.vm.outputs.selectedReward(), project.rewards[endIndex - 1])
  }

+  func testGoToManagePledge_featureNativeCheckoutPledgeView_Enabled() {
+    let config = .template
+      |> Config.lens.features .~ [Feature.nativeCheckoutPledgeView.rawValue: true]


How are we going to proceed from here taking nativeCheckoutV1 into account? Should we test for both of those flags or is nativeCheckoutPledgeView sufficient?

|> \.abExperiments .~ [Experiment.Name.nativeCheckoutV1.rawValue: "experimental"]

The ManagePledgeViewController is only accessible if nativeCheckoutV1 is experimental, because we're presenting from the Rewards Carousel. That said, nativeCheckoutPledgeView should be sufficient.

…wift Co-Authored-By: Pavel Dusatko <pavel.dusatko@gmail.com>

…os-oss into view-pledge-screen

ksr-ci-bot · 2019-09-04T17:30:58Z

	1 Warning
⚠️	Big PR

Generated by 🚫 Danger

dusi

🚢 🚢 🚢
🚢 🚢 🚢
🚢 🚢 🚢

"Quick, merge your PR before Justin"

Scollaco added 6 commits August 30, 2019 15:59

Added ManagePledgeViewController

35d28c0

Added logic to show manage pledge screen

f6a4fd9

Added navigation logic based on feature flag

64b7072

Manage page layout

7b43405

Added tests

c055890

Swiftformat

983bbe4

Scollaco requested review from dusi and cdolm92 September 3, 2019 20:59

Scollaco assigned dusi Sep 3, 2019

Merge branch 'master' into view-pledge-screen

8d0218f

dusi suggested changes Sep 3, 2019

View reviewed changes

Scollaco and others added 10 commits September 4, 2019 10:20

Update Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.s…

ce01882

…wift Co-Authored-By: Pavel Dusatko <pavel.dusatko@gmail.com>

Update Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.s…

9b6b6e8

…wift Co-Authored-By: Pavel Dusatko <pavel.dusatko@gmail.com>

Update Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.s…

1e939e9

…wift Co-Authored-By: Pavel Dusatko <pavel.dusatko@gmail.com>

Update Kickstarter-iOS/Views/Controllers/ManagePledgeViewController.s…

f60182a

…wift Co-Authored-By: Pavel Dusatko <pavel.dusatko@gmail.com>

Feedback from Pavel

b4e76ee

Added test classes

1fb872a

Merge branch 'master' into view-pledge-screen

31636ad

Merge branch 'master' into view-pledge-screen

2adab8b

Added 3 dots image

633dd08

Merge branch 'view-pledge-screen' of https://github.com/kickstarter/i…

55d6d4c

…os-oss into view-pledge-screen

Removed transparency from navigation bar

dcdc881

dusi approved these changes Sep 4, 2019

View reviewed changes

Scollaco merged commit cbcd2ba into master Sep 4, 2019

Scollaco deleted the view-pledge-screen branch September 4, 2019 21:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

View pledge screen #826

View pledge screen #826

Scollaco commented Sep 3, 2019 •

edited by dusi

Loading

dusi left a comment

dusi Sep 3, 2019

Scollaco Sep 4, 2019

dusi Sep 4, 2019

dusi Sep 4, 2019

dusi Sep 3, 2019

dusi Sep 3, 2019

dusi Sep 3, 2019

dusi Sep 3, 2019

Scollaco Sep 4, 2019

dusi Sep 4, 2019

dusi Sep 3, 2019 •

edited

Loading

Scollaco Sep 4, 2019

ksr-ci-bot commented Sep 4, 2019

dusi left a comment

View pledge screen #826

View pledge screen #826

Conversation

Scollaco commented Sep 3, 2019 • edited by dusi Loading

📲 What

🤔 Why

🛠 How

👀 See

✅ Acceptance criteria

With featureNativeCheckoutPledgeView enabled.

With featureNativeCheckoutPledgeView disabled.

dusi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dusi Sep 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ksr-ci-bot commented Sep 4, 2019

dusi left a comment

Choose a reason for hiding this comment

Scollaco commented Sep 3, 2019 •

edited by dusi

Loading

With `featureNativeCheckoutPledgeView` enabled.

With `featureNativeCheckoutPledgeView` disabled.

dusi Sep 3, 2019 •

edited

Loading