[NT-145] Shipping rules search #834
Conversation
| .observeValues { [weak self] indexPath in | ||
| self?.tableView.cellForRow(at: indexPath)?.accessoryType = .none | ||
| .observeValues { [weak self] _ in | ||
| self?.tableView.visibleCells.forEach { $0.accessoryType = .none } |
There was a problem hiding this comment.
This simplified a lot of logic, because we don't have to keep in track previously selected index (this gets really complicated in case the list is filtered causing that previous index to be out of sync).
To simplify this behaviour we simply make sure to deselect cells first, then selecting the latest index.
| .filter { oldIndex, newIndex in oldIndex != newIndex } | ||
| .map(second) | ||
| let searchText = self.searchTextDidChangeProperty.signal | ||
| .ksr_debounce(.milliseconds(100), on: AppEnvironment.current.scheduler) |
There was a problem hiding this comment.
Adding a little bit of delay so that this functionality doesn't cause a bottle neck on slower devices when typing really fast.
Generated by 🚫 Danger |
| @@ -9,14 +9,19 @@ public struct ShippingRuleData: Equatable { | |||
| public let shippingRule: ShippingRule | |||
| } | |||
|
|
|||
| private typealias ShippingRulesInputData = ( | |||
| project: Project, shippingRules: [ShippingRule], selectedShippingRule: ShippingRule | |||
There was a problem hiding this comment.
Might I suggest initialSelectedShippingRule instead of selectedShippingRule to differentiate between the shipping rule that the VC is initially configured with and any future selected rules?
There was a problem hiding this comment.
That's why I called this type Input...but I see how this still could be confusing. 👍
There was a problem hiding this comment.
Technically we're never really accessing this one from the tuple value ¯_(ツ)_/¯
…ng rule after the layout pass
📲 What
Adds the ability to search shipping rules picker.
🤔 Why
Shipping rules picker usually comes with a very long list of locations that we want our users to be able to filter down based on the search term.
🛠 How
The VM had to be completely re-written in order to support search & selection.
😱 Please note that this PR is marked as Big, because there's a lot of tests coverage. The tests should be very descriptive and include a lot of comments.
👀 See
✅ Acceptance criteria
Cancelbutton dismisses the picker