Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-293] Reset reward scroll view on prepareForReuse #843

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Sep 16, 2019

πŸ“² What

Resets the contentOffset of the scroll view in the RewardCell on prepareForReuse to ensure that any new rewards coming into view are scrolled to the top of the reward.

πŸ€” Why

It's visually confusing to see rewards that have already been scrolled.

πŸ›  How

Created a view model for RewardCell, and created an input for the RewardCell collection view cell's prepareForReuse function. This triggers the scrollScrollViewToTopoutput which resets the cells scroll view's contentOffset to it's initial point.

πŸ‘€ See

Trello, screenshots, external resources?

Before πŸ› After πŸ¦‹
NM0nXSGzOE OhB8EECXi7

βœ… Acceptance criteria

  • Navigate to the rewards screen. Find a reward that is longer than the height of the screen and scroll down to the bottom (vertical scrolling). Then, keep scrolling horizontally. All new rewards coming into the screen should be scrolled to the initial starting point. Scrolling back to the previously-scrolled-down reward should show the reward scrolled to it's starting point.

Copy link
Contributor

@cdolm92 cdolm92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this is G2G!! πŸ›³πŸ›³πŸ›³πŸ›³

βœ…ACs passed, tested on iPhone 7

@ifbarrera ifbarrera merged commit 30d4f1d into master Sep 18, 2019
@ifbarrera ifbarrera deleted the rewards-scrolling branch September 18, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants