Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NT-278] Manage pledge menu #846

Merged
merged 14 commits into from
Sep 23, 2019
Merged

[NT-278] Manage pledge menu #846

merged 14 commits into from
Sep 23, 2019

Conversation

ifbarrera
Copy link
Contributor

@ifbarrera ifbarrera commented Sep 19, 2019

📲 What

When tapping the "menu" button on the top right, an action sheet with various options is displayed.

🤔 Why

To allow a user to navigate to various other screens that allow you to modify your pledge.

🛠 How

Depending on the current state of the project, various options are shown.

👀 See

Trello, screenshots, external resources?

Live Project Ended Project iPad
Simulator Screen Shot - iPhone 8 - 2019-09-19 at 10 25 57 Simulator Screen Shot - iPhone 8 - 2019-09-19 at 10 25 49 Simulator Screen Shot - iPad Pro (12 9-inch) - 2019-09-19 at 14 40 36

♿️ Accessibility

  • Tap targets use minimum of 44x44 pts dimensions
  • Works with VoiceOver
  • Supports Dynamic Type

✅ Acceptance criteria

  • Logged in, with both Native Checkout and Native Pledge Screen feature flags turned on, navigate to a live project that you have backed. Tap the "Manage" CTA on the project screen, then tap the navigation button on the top right of the "Manage" screen. You should see the action sheet pop up with 5 options: update pledge, change payment method, choose another reward, contact creator and cancel pledge. Tapping the "Cancel" button should dismiss the action sheet.
  • Logged in, with both Native Checkout and Native Pledge Screen feature flags turned on, navigate to an ended project that you have backed. Tap the "Manage" CTA on the project screen, then tap the navigation button on the top right of the "Manage" screen. You should see the action sheet pop up with 1 options: contact creator. Tapping the "Cancel" button should dismiss the action sheet.

TODOS

  • get confirmation on the accessibility label for the menu navigation bar button

@ifbarrera ifbarrera marked this pull request as ready for review September 19, 2019 14:59
Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great...I'm hesitant about the a11y label, but the rest was mostly just questions/suggestions.

@@ -68,6 +68,9 @@ final class ManageViewPledgeViewController: UIViewController {
_ = self.closeButton
|> \.accessibilityLabel %~ { _ in Strings.Dismiss() }
|> \.width .~ Styles.minTouchSize.width

_ = self.menuButton
|> \.accessibilityLabel %~ { _ in Strings.Manage_your_pledge() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still wondering whether Menu, button would be better because you're already on a screen called Manage your pledge where you navigated by tapping Manage button 😄

let actionSheet = UIAlertController.alert(
title: Strings.Select_an_option(),
preferredStyle: .actionSheet,
barButtonItem: self.menuButton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this works and makes it properly relocate when rotating the device 👍

Library/ViewModels/ManageViewPledgeViewModel.swift Outdated Show resolved Hide resolved
Library/ViewModels/ManageViewPledgeViewModel.swift Outdated Show resolved Hide resolved
@ifbarrera ifbarrera requested a review from dusi September 23, 2019 14:58
Copy link
Contributor

@dusi dusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a11y support!

@ifbarrera ifbarrera merged commit 6491165 into master Sep 23, 2019
@ifbarrera ifbarrera deleted the manage-pledge-menu branch September 23, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants