-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NT-278] Manage pledge menu #846
Conversation
…manage-pledge-menu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great...I'm hesitant about the a11y label, but the rest was mostly just questions/suggestions.
@@ -68,6 +68,9 @@ final class ManageViewPledgeViewController: UIViewController { | |||
_ = self.closeButton | |||
|> \.accessibilityLabel %~ { _ in Strings.Dismiss() } | |||
|> \.width .~ Styles.minTouchSize.width | |||
|
|||
_ = self.menuButton | |||
|> \.accessibilityLabel %~ { _ in Strings.Manage_your_pledge() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still wondering whether Menu, button
would be better because you're already on a screen called Manage your pledge
where you navigated by tapping Manage
button 😄
let actionSheet = UIAlertController.alert( | ||
title: Strings.Select_an_option(), | ||
preferredStyle: .actionSheet, | ||
barButtonItem: self.menuButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this works and makes it properly relocate when rotating the device 👍
…manage-pledge-menu # Conflicts: # Kickstarter-iOS/Views/Controllers/ManageViewPledgeViewController.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📲 What
When tapping the "menu" button on the top right, an action sheet with various options is displayed.
🤔 Why
To allow a user to navigate to various other screens that allow you to modify your pledge.
🛠 How
Depending on the current state of the project, various options are shown.
👀 See
Trello, screenshots, external resources?
♿️ Accessibility
✅ Acceptance criteria
TODOS