[NT-204] Manage pledge payment method section #851
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,141 @@ | ||||
| import KsApi | ||||
| import Library | ||||
| import Prelude | ||||
| import UIKit | ||||
|
|
||||
| final class ManagePledgePaymentMethodView: UIView { | ||||
| // MARK: - Properties | ||||
|
|
||||
| private lazy var cardImageView: UIImageView = { UIImageView(frame: .zero) }() | ||||
| private lazy var cardLabelsStackView: UIStackView = { UIStackView(frame: .zero) }() | ||||
| private lazy var expirationDateLabel: UILabel = { UILabel(frame: .zero) }() | ||||
| private lazy var lastFourLabel: UILabel = { UILabel(frame: .zero) }() | ||||
|
There was a problem hiding this comment.
|
||||
| private lazy var paymentMethodAdaptableStackView: UIStackView = { UIStackView(frame: .zero) }() | ||||
| private lazy var rootStackView: UIStackView = { UIStackView(frame: .zero) }() | ||||
| private lazy var titleLabel: UILabel = { UILabel(frame: .zero) }() | ||||
|
|
||||
| private let viewModel: PledgeCreditCardViewModelType = PledgeCreditCardViewModel() | ||||
|
|
||||
| // MARK: - Lifecycle | ||||
|
|
||||
| override init(frame: CGRect) { | ||||
| super.init(frame: frame) | ||||
|
|
||||
| self.configureViews() | ||||
| self.setupConstraints() | ||||
| self.bindViewModel() | ||||
|
There was a problem hiding this comment. Any update on this @justinswart ? Thought we talked about swizzling some swizzlers to make this automatic :) |
||||
| } | ||||
|
|
||||
| required init?(coder _: NSCoder) { | ||||
| fatalError("init(coder:) has not been implemented") | ||||
| } | ||||
|
|
||||
| // MARK: - Configuration | ||||
|
|
||||
| public func configure(with card: GraphUserCreditCard.CreditCard) { | ||||
| self.viewModel.inputs.configureWith(value: card) | ||||
| } | ||||
|
|
||||
| private func configureViews() { | ||||
| _ = ([self.lastFourLabel, self.expirationDateLabel], self.cardLabelsStackView) | ||||
| |> ksr_addArrangedSubviewsToStackView() | ||||
|
|
||||
| _ = ([self.cardImageView, self.cardLabelsStackView], self.paymentMethodAdaptableStackView) | ||||
| |> ksr_addArrangedSubviewsToStackView() | ||||
|
|
||||
| _ = ([self.titleLabel, self.paymentMethodAdaptableStackView], self.rootStackView) | ||||
| |> ksr_addArrangedSubviewsToStackView() | ||||
|
|
||||
| _ = (self.rootStackView, self) | ||||
| |> ksr_addSubviewToParent() | ||||
| |> ksr_constrainViewToEdgesInParent() | ||||
| } | ||||
|
|
||||
| // MARK: - Styles | ||||
|
|
||||
| override func bindStyles() { | ||||
| super.bindStyles() | ||||
|
|
||||
| _ = self.cardImageView | ||||
| |> cardImageViewStyle | ||||
|
|
||||
| _ = self.cardLabelsStackView | ||||
| |> verticalStackViewStyle | ||||
|
|
||||
| _ = self.expirationDateLabel | ||||
| |> cardExpirationDateLabelStyle | ||||
|
|
||||
| _ = self.lastFourLabel | ||||
| |> cardLastFourLabelStyle | ||||
|
|
||||
| _ = self.paymentMethodAdaptableStackView | ||||
| |> checkoutAdaptableStackViewStyle( | ||||
| self.traitCollection.preferredContentSizeCategory.isAccessibilityCategory | ||||
| ) | ||||
| |> paymentMethodAdaptableStackViewStyle | ||||
|
|
||||
| _ = self.rootStackView | ||||
| |> checkoutCardStackViewStyle | ||||
|
|
||||
| _ = self.titleLabel | ||||
| |> titleLabelStyle | ||||
| } | ||||
|
|
||||
| // MARK: - View model | ||||
|
|
||||
| override func bindViewModel() { | ||||
| super.bindViewModel() | ||||
|
|
||||
| self.expirationDateLabel.rac.text = self.viewModel.outputs.expirationDateText | ||||
| self.lastFourLabel.rac.text = self.viewModel.outputs.cardNumberTextShortStyle | ||||
|
|
||||
| self.viewModel.outputs.cardImage | ||||
|
There was a problem hiding this comment. Can we add empty line here to separate There was a problem hiding this comment. On a second thought, would it be worth it adding reactive extension on the There was a problem hiding this comment. That's a good idea. I can create a ticket for that to be done in a different PR. |
||||
| .observeForUI() | ||||
| .observeValues { [weak self] image in | ||||
| _ = self?.cardImageView | ||||
| ?|> \.image .~ image | ||||
| } | ||||
| } | ||||
|
|
||||
| // MARK: - Functions | ||||
|
|
||||
| private func setupConstraints() { | ||||
| NSLayoutConstraint.activate([ | ||||
| self.cardImageView.widthAnchor.constraint( | ||||
| equalToConstant: CheckoutConstants.PaymentSource.ImageView.width | ||||
|
There was a problem hiding this comment. Isn't this being set by the If we're setting this explicitly to prevent from a weird UI jump could we also set height or aspect ratio constraint (just to be safe)? There was a problem hiding this comment. The constraint is being set here so the views are placed correctly in the stackView. Also, the imageView's contentMode is |
||||
| ) | ||||
| ]) | ||||
| } | ||||
| } | ||||
|
|
||||
| // MARK: - Styles | ||||
|
|
||||
| private let cardExpirationDateLabelStyle: LabelStyle = { label in | ||||
| label | ||||
| |> checkoutTitleLabelStyle | ||||
|
There was a problem hiding this comment. Using
|
||||
| |> \.font .~ UIFont.ksr_caption1().bolded | ||||
| |> \.adjustsFontForContentSizeCategory .~ true | ||||
|
There was a problem hiding this comment. Duplicate of
Suggested change
|
||||
| |> \.textColor .~ UIColor.ksr_text_dark_grey_500 | ||||
| } | ||||
|
|
||||
| private let cardLastFourLabelStyle: LabelStyle = { label in | ||||
| label | ||||
| |> checkoutTitleLabelStyle | ||||
| |> \.font .~ UIFont.ksr_subhead().bolded | ||||
| |> \.adjustsFontForContentSizeCategory .~ true | ||||
|
There was a problem hiding this comment. Duplicate of
Suggested change
|
||||
| |> \.textColor .~ UIColor.ksr_soft_black | ||||
| } | ||||
|
|
||||
| private let paymentMethodAdaptableStackViewStyle: StackViewStyle = { stackView in | ||||
| stackView | ||||
| |> \.spacing .~ Styles.grid(2) | ||||
| } | ||||
|
|
||||
| private let titleLabelStyle: LabelStyle = { label in | ||||
| label | ||||
| |> \.textColor .~ UIColor.black | ||||
| |> \.font .~ UIFont.ksr_subhead().bolded | ||||
| |> \.adjustsFontForContentSizeCategory .~ true | ||||
| |> \.text %~ { _ in Strings.Payment_method() } | ||||
|
There was a problem hiding this comment. I think we'll also need to use |
||||
| |> \.numberOfLines .~ 0 | ||||
| } | ||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add
// MARK: - Configuration??