[NT-296] Round and format amount input based on some rules #857
Conversation
Generated by 🚫 Danger |
| @@ -77,13 +77,13 @@ final class PledgeAmountViewControllerTests: TestCase { | |||
| } | |||
| } | |||
|
|
|||
| func testView_StepperIncrementButtonDisabled_WhenStepperValueSetToMaximum() { | |||
| func testView_StepperIncrementButtonDisabled_WhenStepperValueSetToMaximumStepperValue() { | |||
There was a problem hiding this comment.
Renamed couple tests for better understanding of what min/max are we referring to (since there is stepper min/max value, pledge min/max value, etc.)
|
|
||
| self.currency = project | ||
| .map { currencySymbol(forCountry: $0.country).trimmed() } | ||
|
|
||
| self.stepperMinValue = minValue.mapConst(0) | ||
| self.stepperMaxValue = minValue.mapConst(Double.greatestFiniteMagnitude) | ||
| self.stepperMaxValue = minValue.mapConst(1_000_000_000) |
There was a problem hiding this comment.
I'm not entirely sure what to do about this...we have to set stepper.maxValue since the default value is 100 but I'm not sure to what value. Since we allow inputs bellow pledge minimum, we should also allow inputs above pledge maximum in order to change the text color to red when the input is above that value and still allow stepper / text interactions.
There was a problem hiding this comment.
I think this is fine... it's an arbitrarily high number.
| @@ -122,19 +122,19 @@ internal final class PledgeAmountViewModelTests: TestCase { | |||
| self.doneButtonIsEnabled.assertValues([true]) | |||
|
|
|||
| self.vm.inputs.stepperValueChanged(2) | |||
| self.doneButtonIsEnabled.assertValues([true, true]) | |||
There was a problem hiding this comment.
Mostly skipRepeats for these signals...should have done that before, only noticed now.
dusi
changed the title
|
|
||
| self.currency = project | ||
| .map { currencySymbol(forCountry: $0.country).trimmed() } | ||
|
|
||
| self.stepperMinValue = minValue.mapConst(0) | ||
| self.stepperMaxValue = minValue.mapConst(Double.greatestFiniteMagnitude) | ||
| self.stepperMaxValue = minValue.mapConst(1_000_000_000) |
There was a problem hiding this comment.
I think this is fine... it's an arbitrarily high number.
|
|
||
| // MARK: - Functions | ||
|
|
||
| private func maximumValue() -> Double { |
There was a problem hiding this comment.
Could we have this as a static property on an enum so that we can ensure it's shared between the tests and VM? Something like:
enum PledgeAmountStepperConstants {
static let min: Double = 0
static let max: Double = 1_000_000_000
}
📲 What
What the title says
🤔 Why
It was noticed that rounding was a bit off on the pledge amount field so this work should fix that.
🛠 How
In order to provide great user experience we do have couple rules that we not only round the value but also update the input field
10.0=> `10)This is so that users don't have to manually delete trailing zeros to change the value itself. As soon as there's a legit decimal number we keep it (since that one was most likely intended)
✅ Acceptance criteria
Live user input
minvalue theDonebutton on the keyboard is disabledminvalue the text color is changed to redmaxvalue theDonebutton on the keyboard is disabledmaxvalue the text color is changed to redDismissing keyboard (either by tapping the
Donebutton or tapping anywhere else on the screen) while entering this input results to the following output10(or similar - test with other values) produces1010.(or similar - test with other values) produces1010.0(or similar - test with other values) produces1010.00(or similar - test with other values) produces1010.000(or similar - test with other values) produces1010.1(or similar - test with other values) produces10.1010.01(or similar - test with other values) produces10.0110.99(or similar - test with other values) produces10.9910.999(or similar - test with other values) produces1110.129(or similar - test with other values) produces10.1310.123456789(or similar - test with other values) produces10.12Stepper
+or-button increments/decrements the value properly